From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B9B1A0A0E; Thu, 29 Apr 2021 09:44:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCFC440141; Thu, 29 Apr 2021 09:44:42 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 27E1E4003E for ; Thu, 29 Apr 2021 09:44:41 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 1CA66580749; Thu, 29 Apr 2021 03:44:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 29 Apr 2021 03:44:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= UZyte083enECdxHCNm0uaUe1BCXK+FyhC8rRfsAVGMY=; b=NfyZlQ1DPkY+N6hv Wln13NzKWJLHB2/dz+3l5XcwwwAYy7gv70Ot0Teu/O5k9cBxcxf+GlrFmQqKaaoT zFrnawneVR2iIHOVOfaNNh0srR1RbK2uJEACAL+EHgfRWZ3rojLhXj/tRA8jj0Vf bXTzlJS0rQI6VF9waMrWBu0MZ8bH40wgfLQ1/E7nUsN3k5Yz5E5Ss4egAi1octuU zyRpFpnUwm46qbiyZEp4E7iKeuxTjtgRUXancxPBC9y31m6GYvS53XfRtzWdqsoi GVTY6HXJPi9H9rlzsX39OTHSwu6r8rNdog2I4/yHHS+GRkPeq+Y1HRW2OdIFfBSJ /jOIIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UZyte083enECdxHCNm0uaUe1BCXK+FyhC8rRfsAVG MY=; b=YWSwvPCVgqE7hgxxDkLzYWzcxK6gEZbVyI93P4OvCV5C1hSXosXjo4ogg iy2cF7B4IRbF0QzV5PAJi1zmhurtFQs+fo/tLNtjTY1FsngZaCzTeeUWwrctaSKL DuilMVltm2bj5HbcB2Azx/3pA+rfBaj5Cjq20AVkpQlsX4RI/sshNr47ys9rIiP9 pDoDonaViWvIkOTSGdV3Bpm4fMvbnfljgciIqFwP19t7PWn9/efV2t6ZHiiZli2y qhDTDuvJlaRsfv2tKoP4GssATNrWe55v3zchiIIXziYVAydJP0uwEShgZMZdfwDh XOt6vJQF8TZS8+Axec2xlCi0jJYVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvfedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Apr 2021 03:44:35 -0400 (EDT) From: Thomas Monjalon To: Narcisa Ana Maria Vasile , Dmitry Kozlyuk Cc: dev@dpdk.org, khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com, mdr@ashroe.eu Date: Thu, 29 Apr 2021 09:44:33 +0200 Message-ID: <33056936.xYFp2keEGj@thomas> In-Reply-To: <20210429035029.349d3306@sovereign> References: <1617057640-24301-2-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-2-git-send-email-navasile@linux.microsoft.com> <20210429035029.349d3306@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 01/10] eal: add thread id and simple thread functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/04/2021 02:50, Dmitry Kozlyuk: > 2021-04-02 18:38 (UTC-0700), Narcisa Ana Maria Vasile: > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/rte_windows_thread_types.h > > @@ -0,0 +1,12 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2021 Microsoft Corporation > > + */ > > + > > +#ifndef _RTE_THREAD_TYPES_H_ > > +#define _RTE_THREAD_TYPES_H_ > > + > > +#include > > + > > +typedef DWORD rte_thread_t; > > + > > +#endif /* _RTE_THREAD_TYPES_H_ */ > > pthread_t type in pthreads-win32 and winpthread is not 32 bit. > DPDK will have different ABI depending on a threading backend used. > Apps must know it at build time then. How do they discover it? > This is worth a warning in commit log and docs. Not sure this is an acceptable behaviour. In my opinion, ABI should not vary. +Cc Ray