Re: [dpdk-dev] [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function

[Thomas Monjalon <thomas@monjalon.net>]

28/11/2018 10:27, Eelco Chaudron:
> On 28 Nov 2018, at 9:38, David Marchand wrote:
> > On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron <echaudro@redhat.com> 
> > wrote:
> >> --- a/lib/librte_meter/Makefile
> >> +++ b/lib/librte_meter/Makefile
> >> -LIBABIVER := 2
> >> +LIBABIVER := 3
> >
> > As far as I understood the policy around the EXPERIMENTAL section, you
> > don't need to bump the library version.
> 
> Thought I would add the new function as none experimental, i.e. next 
> version, but checkpatch did not allow me to do this.
> 
> Tried to find info on what the right process was, as these functions are 
> just another meter implementation using similar existing APIs. If anyone 
> has any background on this please point me to it.

It is documented here:
	http://doc.dpdk.org/guides/contributing/versioning.html

The case for "similar API" is not handled specifically so far.
So you need to introduce it as experimental.

> I changed the library version as an existing data structure changed 
> (which in theory should not change the location of the data), but the 
> ABI check popped warnings so I decided to increase the version.

It deserves to analyze why the ABI check raises a warning.
If it really needs to bump the ABI version, you should justify it
in the commit message, and explain what changed in the ABI section
of the release notes, plus update the version in the release notes.