From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 369831B206 for ; Wed, 28 Nov 2018 11:09:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 83EFEA3B; Wed, 28 Nov 2018 05:09:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Nov 2018 05:09:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cZwCbAu3JIp5IpsBYY+Wv9iD9DOeDhpWRFX48D5G5qI=; b=oSnWZD0Y4+Mj c+YE6oPdUJrC0wrFEBUUK8C8MjsQSG6lfXrmP+2/BuhDRISDfM47H7RwqEC23wci dZ3cYVrNStBDua6zWasxq/sbMz8P1/y5FxdaLr83ezejwbOYrdlw0frn3N5V0s+J t6G0XgmJhQmfD8qW9EUUKT3ebKY61eQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cZwCbAu3JIp5IpsBYY+Wv9iD9DOeDhpWRFX48D5G5 qI=; b=fytDO3jpm/CcfjyX6l3PtUA3BBFGMkpbcXcv9zlkVzfj79q7N1Q7YiUoe O6KJJa23e2XUq+c2C4rWTI5xhLgpmtDI+/OsByAvXacYSEyt40G3hacaS8lCgMkX utaq/oNXCBAgWXTDQmMGR7Lp+r3rYa9VSorPVu97ZFqIhu6M9fv6nXuv/bvqSqz1 Js7V1Rrq23x5I4uegXjIU/SeC7IoJ6yXHZ2TF+1hBw5iR7dS+crDbkq05o9zHyKD GgVPJrZLAy2JJM+rAwQeNZSIOknSmQiLJZi/JJ7SgBJ3EnjChDpjwftWC8ZxvVmI zP0LRRmThpb441lxj2BnP8q7vFAsg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 16E94E4898; Wed, 28 Nov 2018 05:09:49 -0500 (EST) From: Thomas Monjalon To: Eelco Chaudron Cc: dev@dpdk.org, David Marchand , cristian.dumitrescu@intel.com Date: Wed, 28 Nov 2018 11:09:47 +0100 Message-ID: <3306361.jWiN20gDd9@xps> In-Reply-To: References: <154333204294.44971.12989297399338053044.stgit@dbuild> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 10:09:52 -0000 28/11/2018 10:27, Eelco Chaudron: > On 28 Nov 2018, at 9:38, David Marchand wrote: > > On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron > > wrote: > >> --- a/lib/librte_meter/Makefile > >> +++ b/lib/librte_meter/Makefile > >> -LIBABIVER := 2 > >> +LIBABIVER := 3 > > > > As far as I understood the policy around the EXPERIMENTAL section, you > > don't need to bump the library version. > > Thought I would add the new function as none experimental, i.e. next > version, but checkpatch did not allow me to do this. > > Tried to find info on what the right process was, as these functions are > just another meter implementation using similar existing APIs. If anyone > has any background on this please point me to it. It is documented here: http://doc.dpdk.org/guides/contributing/versioning.html The case for "similar API" is not handled specifically so far. So you need to introduce it as experimental. > I changed the library version as an existing data structure changed > (which in theory should not change the location of the data), but the > ABI check popped warnings so I decided to increase the version. It deserves to analyze why the ABI check raises a warning. If it really needs to bump the ABI version, you should justify it in the commit message, and explain what changed in the ABI section of the release notes, plus update the version in the release notes.