From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 831155A for ; Fri, 29 Mar 2019 12:50:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 00527216C5; Fri, 29 Mar 2019 07:50:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 07:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Oy2EOw1XDdwAGAfJM5KAPCMztVKSUwdFu/q18aU11kE=; b=Jn7Rn8WkawXQ FCBnxhXX0pc1L8IQsL2L2Zh0hmuc+k6c+2SgPG40LS9yKo8CJiHwsl5q0obUUuZy 0gaWCIWqXMsFX+JUCOdV1miKnPmnt8Lj+TVvF9WIzgjgRMh2IWLbDtd5JUHasBo0 7cHn5prFF+D2FoWarYMI5BeInZj5Pm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Oy2EOw1XDdwAGAfJM5KAPCMztVKSUwdFu/q18aU11 kE=; b=emVqUgedJyE1sUVjt9F2ZfXw6XgWXMsmujhxbpy/eDPIIQMZy0+Oi8om7 j4uKGNImMT+qmD/wlstdkph2S5kjJ6JkXa2Zq0dPmiFtDgQefukrqaqPMrpYkn2J +mIUfH84JctIk/Y/VXurzzvJ5b6StFgn86CUdH+kj6oysLhwmPZySyLAlFaig+jj TkF80HRTwkOjk2+2gb5vtUqmaf8RwQ3p2ipPSCyCPz0keQhBYULP7Fnr3hjIgQaV zlWXmXyQeA+oNhlSqlVaipwtnCexCVg6yURM/Ojo9g1JHaKGdEO18PgEBMaQL9FT hj0ke+pp/gRS+2Ln9daDQN5k76srw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeejgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CF03100E5; Fri, 29 Mar 2019 07:50:23 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, dariusz.stojaczyk@intel.com, gavin.hu@arm.com Date: Fri, 29 Mar 2019 12:50:22 +0100 Message-ID: <33065672.VFaiPrc4eW@xps> In-Reply-To: <35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com> References: <35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fbarray: fix init unlock without lock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 11:50:25 -0000 29/03/2019 11:57, Anatoly Burakov: > Certain failure paths of rte_fbarray_init() will unlock the > mem area lock without locking it first. Fix this by properly > handling the failures. > > Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for mapped areas") > > Signed-off-by: Anatoly Burakov Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B609AA05D3 for ; Fri, 29 Mar 2019 12:50:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2A331B05; Fri, 29 Mar 2019 12:50:26 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 831155A for ; Fri, 29 Mar 2019 12:50:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 00527216C5; Fri, 29 Mar 2019 07:50:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 07:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Oy2EOw1XDdwAGAfJM5KAPCMztVKSUwdFu/q18aU11kE=; b=Jn7Rn8WkawXQ FCBnxhXX0pc1L8IQsL2L2Zh0hmuc+k6c+2SgPG40LS9yKo8CJiHwsl5q0obUUuZy 0gaWCIWqXMsFX+JUCOdV1miKnPmnt8Lj+TVvF9WIzgjgRMh2IWLbDtd5JUHasBo0 7cHn5prFF+D2FoWarYMI5BeInZj5Pm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Oy2EOw1XDdwAGAfJM5KAPCMztVKSUwdFu/q18aU11 kE=; b=emVqUgedJyE1sUVjt9F2ZfXw6XgWXMsmujhxbpy/eDPIIQMZy0+Oi8om7 j4uKGNImMT+qmD/wlstdkph2S5kjJ6JkXa2Zq0dPmiFtDgQefukrqaqPMrpYkn2J +mIUfH84JctIk/Y/VXurzzvJ5b6StFgn86CUdH+kj6oysLhwmPZySyLAlFaig+jj TkF80HRTwkOjk2+2gb5vtUqmaf8RwQ3p2ipPSCyCPz0keQhBYULP7Fnr3hjIgQaV zlWXmXyQeA+oNhlSqlVaipwtnCexCVg6yURM/Ojo9g1JHaKGdEO18PgEBMaQL9FT hj0ke+pp/gRS+2Ln9daDQN5k76srw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeejgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CF03100E5; Fri, 29 Mar 2019 07:50:23 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, dariusz.stojaczyk@intel.com, gavin.hu@arm.com Date: Fri, 29 Mar 2019 12:50:22 +0100 Message-ID: <33065672.VFaiPrc4eW@xps> In-Reply-To: <35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com> References: <35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fbarray: fix init unlock without lock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329115022.TFpx55B4ym_E-cDUmQepBoeKKLn6jGxvN1XgUgimDcI@z> 29/03/2019 11:57, Anatoly Burakov: > Certain failure paths of rte_fbarray_init() will unlock the > mem area lock without locking it first. Fix this by properly > handling the failures. > > Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for mapped areas") > > Signed-off-by: Anatoly Burakov Applied, thanks