From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5ECDC433E5;
Mon, 27 Nov 2023 14:16:25 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E06BF40273;
Mon, 27 Nov 2023 14:16:24 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
by mails.dpdk.org (Postfix) with ESMTP id 800D74014F
for <dev@dpdk.org>; Mon, 27 Nov 2023 14:16:23 +0100 (CET)
Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57])
by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Sf5bw2XppzsRZj;
Mon, 27 Nov 2023 21:12:44 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com
(7.193.23.18) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 27 Nov
2023 21:16:20 +0800
Message-ID: <330a8e4e-8cd4-0255-7eda-26cca3b18b69@huawei.com>
Date: Mon, 27 Nov 2023 21:16:19 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH v3 2/6] doc: add link up/down feature
To: Ferruh Yigit <ferruh.yigit@amd.com>, <dev@dpdk.org>
CC: <liuyonglong@huawei.com>, <thomas@monjalon.net>, Changchun Ouyang
<changchun.ouyang@intel.com>
References: <20231123135916.33315-1-lihuisong@huawei.com>
<20231125014745.61348-1-lihuisong@huawei.com>
<20231125014745.61348-3-lihuisong@huawei.com>
<a9e8ad8f-e056-42d5-8d9e-74caada12128@amd.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <a9e8ad8f-e056-42d5-8d9e-74caada12128@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
kwepemm000004.china.huawei.com (7.193.23.18)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
在 2023/11/27 20:24, Ferruh Yigit 写道:
> On 11/25/2023 1:47 AM, Huisong Li wrote:
>> Add link up/down feature for features.rst.
>>
>> Fixes: 915e67837586 ("ethdev: API for link up and down")
>> Cc: stable@dpdk.org
>>
> Documentation is added after feature, so above fixes line is not correct.
>
> I am not sure if this is fix, I think more like it is extending the
> document.
>
>
> With fixes line fix,
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
Ok just to add Cc stable.
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>> ---
>> doc/guides/nics/features.rst | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
>> index 0d38c5c525..f14962a6c3 100644
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -45,6 +45,10 @@ Supports getting the link speed, duplex mode and link state (up/down).
>> * **[implements] rte_eth_dev_data**: ``dev_link``.
>> * **[related] API**: ``rte_eth_link_get()``, ``rte_eth_link_get_nowait()``.
>>
>> +Set link up/down an Ethernet device.
>> +
>> +* **[implements] eth_dev_ops**: ``dev_set_link_up``, ``dev_set_link_down``.
>> +* **[related] API**: ``rte_eth_dev_set_link_up()``, ``rte_eth_dev_set_link_down()``.
>>
>> .. _nic_features_link_status_event:
>>
>
> .