From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id B174D29C7 for ; Thu, 3 Mar 2016 01:31:28 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id l68so11301819wml.1 for ; Wed, 02 Mar 2016 16:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=mqJs4KzZti1yiFRH1u2rKogf1lemKCmxsmBApMupNNE=; b=bSIagYA+VnvviAZAi4xu5lAaTBk/mFFjE3h2awj34UCNUaC69OQ4O7WbGtjavo1/21 9WN5BepWnFLMKVvqIdvctP4TQpw2VF5alYU9Y7xN/nfxKjprnB4BK5vpYvLGmHZKNA0u M8d5b2FqwL5C3H4WfINQiJ6t/HGmiZ5ue+foQYd+nuV2E0RS8NQgEndOTZEM5GnjxsuD PcPEg2j+WC2W3br/6QxOICsexCRzbn6ThGC0oxxNxUb3K8GQCZCDtel/N/zCVdDYTvjG izdu+IrqTHzM9O3WiShDGCA4qTKIObBO1+rk2o1hHECq3vQop5F8xPuw5+ThW3lEY7Uf aGQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=mqJs4KzZti1yiFRH1u2rKogf1lemKCmxsmBApMupNNE=; b=N2TIKTrnfvJ3w5E1RdFglHyo6mv2EaAvru24A6obdmYIY6eM7cLN+i2GepWSTnLBrW LEyST/Jv9iM8CJ2zRFhi6TlueNIaevxPjIvrDO9iZVknjSntmc56uZhGtTw4cmy+vtqT 8arMsSHR3PSj/Lix0Ro6chNSziLF695kmmItlTd8pljPk6WwbjsoYUqxXqqqUIZX/Qx+ /TpS+KCapjFCEnb9mPkk1580ErOwgz9NiMvdfQ8FWZLpzzVoESmtCcO14kAukcKIRwzm 2sK8go1782fssMQM/gotvYonv4GXvYXhsnP9Tfh5If0lRzWe99oY1jl2YNLV/LV5qB1C RWEw== X-Gm-Message-State: AD7BkJITd4XHj1fY5G4xpZGxpk7gWB/zyH0VK3hbpt48eMxbLAg5jlq2va7nA2WvZV6B/Q1U X-Received: by 10.28.182.194 with SMTP id g185mr2610462wmf.41.1456965088475; Wed, 02 Mar 2016 16:31:28 -0800 (PST) Received: from xps13.localnet ([93.158.47.166]) by smtp.gmail.com with ESMTPSA id 202sm6456329wmo.7.2016.03.02.16.31.26 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Mar 2016 16:31:27 -0800 (PST) From: Thomas Monjalon To: Stephen Hurd Date: Thu, 03 Mar 2016 01:29:51 +0100 Message-ID: <3312508.fJgjDDEF6G@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <3156888.xIWalfADA6@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, David Christensen , Carl Tung Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 00:31:29 -0000 2016-03-02 15:10, Stephen Hurd: > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon > wrote: > > > The driver itself doesn't have a lot of optional features in it, it's the > > > header file that's too big. > > > > It is big because there are many different things. > > You can split the file in different patches. > > Examples: > > - a patch for RSS will bring the hardware structures for RSS > > - a patch for the stats will bring the hardware stats structures > > etc > > Should I split additional definitions/documentation that's not currently > used in the driver as well? Or should it stay as only enough to document > what the driver already does? I don't understand the question. If something is not used, it should not been there. > It's a fairly work-intensive project to deconstruct the existing driver > into a series of small patches that work at each step, is this a hard > requirement? (if so, I'd better get cracking) There is no hard requirement. I'm just giving you some advices to get some reviewers and make them confident when accepting your patches. By the way, you would get more attention by introducing the device with some web links and performance numbers in the cover letter. It is also appreciated to provide a documentation in doc/guides/nics/. You could also fill the (new) table in overview.rst. Thanks