From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13E4643D3E; Sun, 24 Mar 2024 23:25:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E37C40289; Sun, 24 Mar 2024 23:25:40 +0100 (CET) Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id F2EEF40281 for ; Sun, 24 Mar 2024 23:25:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 41ED5138009D; Sun, 24 Mar 2024 18:25:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 24 Mar 2024 18:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1711319138; x=1711405538; bh=r5noEXW1iQIg74OxzYiaAKM1yZpJhStMpGqoHekGdcA=; b= inpOwAPlwR2uPHV6U1xQkI2outLqz3NLqHVWIF+5/Ns/Y3N2SHGKW/ih4U6OFmBX tm+vgCfB+TgVBhixq2aAaEVnP66Shzv+lxOOMR1v4wt7bG65kyuMa6HfEuz3PiJy A4oq9IN17ZFYNDZNkdtENp1saebqtNBm131ZXfN39ivlRWbllEg/xPeRmNw3Wtpu viHiQaAP4T9JyuegBJt/otbYBO0vQwn4J8jEG/kKP1sdawqqdWri2+NoVly9Ahjf yCApe2oHw0ehCSYefzo7o1mhJvPPOCbNvB2h5y125uptAMYs7Vula+tmyy7YoC4Z h2Zy9xhSFZ7499abIyEhuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711319138; x= 1711405538; bh=r5noEXW1iQIg74OxzYiaAKM1yZpJhStMpGqoHekGdcA=; b=f zUu7HPBxHwRNI8v62lRIl5sAblgyiCZqqDaiDMWtGevililw67yfpquHSjrUuwEG O/52jPCS9DgxhTLNvcbYNhBJTmZw3v+CvKE7sWClgy0DObtfiO1v/QHNsIBY/Cba FEJG94cNMmK0ts+A7jnJb6VEW5S5fJnBiRNaosBiaomodMKh4QQsfn3xk7DyUVhl HR0GAZNS00lDgi2kkjPhJwABjQ9wNBQ0Z1LkzMN6nxLWi+m5vqau+n+xvg0d0f0g hr2vr6rjsUjY93tO2CgG5zhBN0JCci0oNPG6nlgoBUMzhheEMtyFO+z7iRHvx19R waa58sEMPCT12sx6lkDRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddtjedgudeigecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeeg kefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 24 Mar 2024 18:25:36 -0400 (EDT) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, mkashani@nvidia.com, rasland@nvidia.com, Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: Re: [PATCH v2] net/mlx5: fix sync meter action Date: Sun, 24 Mar 2024 23:25:35 +0100 Message-ID: <3313057.clyjiGRsXx@thomas> In-Reply-To: <20240319112455.329350-1-getelson@nvidia.com> References: <20240318181045.272879-1-getelson@nvidia.com> <20240319112455.329350-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/03/2024 12:24, Gregory Etelson: > PMD implements sync METER flow action as async. > Queue selected for sync operations is `MLX5_HW_INV_QUEUE`. > That dummy queue value is translated into `CTRL_QUEUE_ID(priv)`. > Async job allocation converts INV queue into the real value, but > job release does not. > > This patch fixes the queue value provided to `flow_hw_job_put()`. > > This patch also removes dead code found in METER_MARK > destroy handler. > > Coverity issue: 415806 > Coverity issue: 415804 > > Fixes: 4359d9d1f76b ("net/mlx5: fix sync meter processing in HWS") > > Signed-off-by: Gregory Etelson > Acked-by: Dariusz Sosnowski Applied, thanks.