DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] config: add static linkage of mlx dependency
Date: Wed, 09 Jan 2019 11:02:21 +0100	[thread overview]
Message-ID: <3313625.hlFx3BV45W@xps> (raw)
In-Reply-To: <20190109093738.GB2940@bricha3-MOBL.ger.corp.intel.com>

09/01/2019 10:37, Bruce Richardson:
> On Wed, Jan 09, 2019 at 03:05:24AM +0100, Thomas Monjalon wrote:
> > The libraries provided by rdma-core may be statically linked
> > if enabling CONFIG_RTE_IBVERBS_LINK_STATIC in the make-based build.
> > If CONFIG_RTE_BUILD_SHARED_LIB is disabled,
> > the applications will embed the mlx PMDs with ibverbs and the mlx libraries.
> > If CONFIG_RTE_BUILD_SHARED_LIB is enabled,
> > the mlx PMDs will embed ibverbs and the mlx libraries.
> > 
> > Support with meson may be added later.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Just to clarify - if there is a shared library build, the idea is to
> actually link in the dependent .a files directly into the .so, rather than
> having the driver .so's track their dependency on the other .so files? What
> is the prospective use-case for this, and can it cause problems? I thought
> it was generally not advisable to be linking in static libraries into
> shared libraries.

Yes that's it.
It is supposed to ease the packaging for some users,
because there are less packages to install on the target host.
For instance, VPP may be interested.

If rdma-core is not linked by the application, I don't see any issue.

  reply	other threads:[~2019-01-09 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  2:05 [dpdk-dev] [PATCH 1/2] config: gather options for dlopen " Thomas Monjalon
2019-01-09  2:05 ` [dpdk-dev] [PATCH 2/2] config: add static linkage of " Thomas Monjalon
2019-01-09  9:37   ` Bruce Richardson
2019-01-09 10:02     ` Thomas Monjalon [this message]
2019-01-09  7:51 ` [dpdk-dev] [PATCH 1/2] config: gather options for dlopen " Shahaf Shuler
2019-01-09  9:33 ` Bruce Richardson
2019-01-09  9:55   ` Thomas Monjalon
2019-01-09 14:23 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2019-01-09 14:23   ` [dpdk-dev] [PATCH v2 2/2] config: add static linkage of " Thomas Monjalon
2019-01-09 15:03   ` [dpdk-dev] [PATCH v2 1/2] config: gather options for dlopen " Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3313625.hlFx3BV45W@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).