From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 03/10] igb_uio: dont wrap pci_num_vf function needlessly
Date: Wed, 23 Jul 2014 10:20:36 +0200 [thread overview]
Message-ID: <3316831.ltehqHH9ix@xps13> (raw)
In-Reply-To: <20140718161516.157268908@networkplumber.org>
2014-07-18 09:14, Stephen Hemminger:
> /* sriov sysfs */
> -int local_pci_num_vf(struct pci_dev *dev)
> -{
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,34)
> +static int pci_num_vf(struct pci_dev *dev)
> struct iov {
> int pos;
> int nres;
A brace is missing here.
Fixed in master branch:
http://dpdk.org/browse/dpdk/commit/?id=282e1ec8570
--
Thomas
next prev parent reply other threads:[~2014-07-23 8:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 16:14 [dpdk-dev] [PATCH 00/10] igb_uio related patches Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 01/10] igb_uio: use kernel standard log message Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 02/10] igb_uio: use standard uio naming Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 03/10] igb_uio: dont wrap pci_num_vf function needlessly Stephen Hemminger
2014-07-23 8:20 ` Thomas Monjalon [this message]
2014-07-18 16:14 ` [dpdk-dev] [PATCH 04/10] igb_uio: msix cleanups Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 05/10] igb_uio: propogate error numbers in probe code Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 06/10] igb_uio: make irq mode param read-only Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 07/10] igb_uio: fix IRQ mode handling Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 08/10] igb_uio: add missing locking to config access Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 09/10] igb_uio: allow msi mode Stephen Hemminger
2014-07-18 16:14 ` [dpdk-dev] [PATCH 10/10] igb_uio: fix check patch warnings Stephen Hemminger
2014-07-19 0:16 ` [dpdk-dev] [PATCH 00/10] igb_uio related patches Thomas Monjalon
2014-07-20 8:14 ` Yerden Zhumabekov
2014-07-21 10:28 ` Thomas Monjalon
2014-07-21 12:03 ` [dpdk-dev] [igb_uio PATCH 0/3] igb_uio: fixed typos and pci lock/unlock calls Yerden Zhumabekov
2014-07-21 12:03 ` [dpdk-dev] [igb_uio PATCH 1/3] igb_uio: fixed typos Yerden Zhumabekov
2014-07-21 12:03 ` [dpdk-dev] [igb_uio PATCH 2/3] igb_uio: pci_config_lock/pci_config_unlock wrappers Yerden Zhumabekov
2014-07-21 20:42 ` Stephen Hemminger
2014-07-21 20:50 ` Thomas Monjalon
2014-07-22 12:57 ` Thomas Monjalon
2014-07-21 12:03 ` [dpdk-dev] [igb_uio PATCH 3/3] igb_uio: renaming pci config lock/unlock functions Yerden Zhumabekov
2014-07-21 19:51 ` [dpdk-dev] [igb_uio PATCH 0/3] igb_uio: fixed typos and pci lock/unlock calls Thomas Monjalon
2014-07-22 13:07 ` Thomas Monjalon
2014-07-24 21:50 ` Thomas Monjalon
2014-07-25 16:51 ` Stephen Hemminger
2014-07-21 15:38 ` [dpdk-dev] [PATCH " Yerden Zhumabekov
2014-07-21 15:38 ` [dpdk-dev] [PATCH 1/3] igb_uio: fixed typos Yerden Zhumabekov
2014-07-21 15:38 ` [dpdk-dev] [PATCH 2/3] igb_uio: pci_config_lock/pci_config_unlock wrappers Yerden Zhumabekov
2014-07-21 15:38 ` [dpdk-dev] [PATCH 3/3] igb_uio: renaming pci config lock/unlock functions Yerden Zhumabekov
2014-07-21 19:54 ` [dpdk-dev] [PATCH 0/3] igb_uio: fixed typos and pci lock/unlock calls Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3316831.ltehqHH9ix@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).