From: Thomas Monjalon <thomas@monjalon.net>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
conor.walsh@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] fib: add rib extension size parameter
Date: Wed, 27 Oct 2021 10:28:14 +0200 [thread overview]
Message-ID: <3325908.4ItypYI1PS@thomas> (raw)
In-Reply-To: <88c45098-747c-6267-049c-5569b8cf5e96@intel.com>
26/10/2021 22:30, Medvedkin, Vladimir:
> Hi Thomas,
>
> On 25/10/2021 19:23, Thomas Monjalon wrote:
> > 06/09/2021 17:55, Vladimir Medvedkin:
> >> This patch adds a new parameter to the fib configuration to specify
> >> the size of the extension for internal RIB structure.
> >
> > It looks to be an announced API change.
> > What happens if the new field is not initialized in the app?
> > At least it would deserve a note in the release notes in API changes I think.
> >
>
> This patch was sent for an experimental library, so no update was required.
> In the patch about the promotion of the FIB API to stable:
>
> https://patches.dpdk.org/project/dpdk/patch/1630944075-363524-1-git-send-email-vladimir.medvedkin@intel.com/
>
> I put a note about this patch and mentioned that it should be applied
> before promotion API to stable.
Indeed, we did not wait.
> Can we accept it now or we have to wait for next LTS release?
I think it is OK in this release.
You didn't reply about the release notes. Should we notify an API change?
Note: even experimental functions should be notified in release notes
if it requires a code change in the app.
next prev parent reply other threads:[~2021-10-27 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 15:55 Vladimir Medvedkin
2021-09-08 16:59 ` Conor Walsh
2021-10-25 17:23 ` Thomas Monjalon
2021-10-26 20:30 ` Medvedkin, Vladimir
2021-10-27 8:28 ` Thomas Monjalon [this message]
2021-10-27 15:47 ` Medvedkin, Vladimir
2021-10-27 15:49 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2021-11-04 11:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3325908.4ItypYI1PS@thomas \
--to=thomas@monjalon.net \
--cc=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).