From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D501EA0C45; Wed, 27 Oct 2021 10:28:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C12FD40E0F; Wed, 27 Oct 2021 10:28:19 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 3D6954003F for <dev@dpdk.org>; Wed, 27 Oct 2021 10:28:18 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DBEE45C02B4; Wed, 27 Oct 2021 04:28:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 27 Oct 2021 04:28:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1iJexFExeVNhebqZn0s+g7r+LzY2bX3UsMR319P7WLE=; b=fXmMmt4jcxCd2G3Y nEO0nhv5rKoZumnA5+YpavOe3AKiAClJAMYVufJ3I9zSjyc0JYZZPE2hSMONEc6/ 4yCjPCNu8qrcLRSJNWxGE4WV4+YXOczyjugQO0G5GIvUZl4L72GpR/54kW7+5jR7 jQbH8ckyydUkO7lE7qdubul0UVKy3y6DnMnzgWGw4OrpqEje+jhXcTpypDQclO5w q0+nNeg3L9gjLmqRsxuyD4WFwWU8p3ib96+V3+fIXgXdK47Eu3YR3uOTn2HBs7Jh EOrk7k19d23/JLkiB7wevBYgHAjM4Hzufycxw3aeQ5zFRBUWR0DpDb5yziigdMyf iipSkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1iJexFExeVNhebqZn0s+g7r+LzY2bX3UsMR319P7W LE=; b=GToWekrVGG9iHWd5nvjapf2iQgODJBiET4eAVh0KW01P7Huvg00bbnFnt Jkbv/5xII+Ffsuj1rRCjfkiT/bBohSjZpatDoQ+osfEmpMoGog2qcTgaBUTzvH3D XIZHXSsyaXQ9fA+mp+n0HQYyjw44XLOM0JBwcPuQeJoo1Wzr1vn4zemtoevGmBVf ZDTww/cBo0UV/lzBCh+YgQZPER24XDvAWodltGaOcmf6+IPPKwlwHUSDRLf0I2yR 11YaJPh0dGSZtSdSw2utPXAmle9izB2oM4vcSl3BGxMA3whvKGWzBUXg9GWzIJmX iIuhb5TBGDzow1KeoXdovBT+sPTkQ== X-ME-Sender: <xms:oA15YRab6NN2YZIeA3nhk1VTibPLZkAc9od-_hWMSObBOslcimYwwQ> <xme:oA15YYbonYn_I9l-4H5WcILdH5jKt803p6Imc48P3eOc8toiar1MSInzy32A3m7UZ cXrx5Uht7RDUN_hxQ> X-ME-Received: <xmr:oA15YT-9DP7pNtnQIzgzSACTiWLH6OgWMh9pKTF4D5_Q5gtKJ9vOXZYYEQpsAqchaWmTWg94qbARLjIYNM4yMGbEMQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: <xmx:oA15YfqZavogC7guNUhntuw1GCUXi6G4HCRcILa8bI1f1ViZIyHRqw> <xmx:oA15YcrvdWBMUF8gRLegRVQBc_uYd_yQSBjeS7a3e8RWmEb7LmHrUg> <xmx:oA15YVQxxcJv6p8wHbU3ApWA2bdl8ZVAczKVcwGCcwOPNgVc-0mCgw> <xmx:oA15YXXt2sdKbuCONio3yOdS85Upd2L_mgaR3-DY2htBnbPdEhhO1Q> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 04:28:15 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com> Cc: dev@dpdk.org, konstantin.ananyev@intel.com, conor.walsh@intel.com, david.marchand@redhat.com Date: Wed, 27 Oct 2021 10:28:14 +0200 Message-ID: <3325908.4ItypYI1PS@thomas> In-Reply-To: <88c45098-747c-6267-049c-5569b8cf5e96@intel.com> References: <1630943759-362969-1-git-send-email-vladimir.medvedkin@intel.com> <8937505.KMVrHqqNeC@thomas> <88c45098-747c-6267-049c-5569b8cf5e96@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fib: add rib extension size parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 26/10/2021 22:30, Medvedkin, Vladimir: > Hi Thomas, > > On 25/10/2021 19:23, Thomas Monjalon wrote: > > 06/09/2021 17:55, Vladimir Medvedkin: > >> This patch adds a new parameter to the fib configuration to specify > >> the size of the extension for internal RIB structure. > > > > It looks to be an announced API change. > > What happens if the new field is not initialized in the app? > > At least it would deserve a note in the release notes in API changes I think. > > > > This patch was sent for an experimental library, so no update was required. > In the patch about the promotion of the FIB API to stable: > > https://patches.dpdk.org/project/dpdk/patch/1630944075-363524-1-git-send-email-vladimir.medvedkin@intel.com/ > > I put a note about this patch and mentioned that it should be applied > before promotion API to stable. Indeed, we did not wait. > Can we accept it now or we have to wait for next LTS release? I think it is OK in this release. You didn't reply about the release notes. Should we notify an API change? Note: even experimental functions should be notified in release notes if it requires a code change in the app.