From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F1ABA09E8; Tue, 8 Dec 2020 16:52:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 878D572D9; Tue, 8 Dec 2020 16:52:47 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 3233998 for <dev@dpdk.org>; Tue, 8 Dec 2020 16:52:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 19C07B2F; Tue, 8 Dec 2020 10:52:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 08 Dec 2020 10:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= cgPFEQykmhyZD2YLQ47aCJMzAxnB6OPQ1+SuXbXj7LY=; b=NKg1ucCkORQBg6Ps k5o54Aisbhgh8zpMM0qVi7jhgkIOKMiSV3vHlQDbA52PxD/Oq3Cgf08eaRCUMQi7 6CUhgAjhS8S31nGiZ8X8w4bsh21BcaAwV0NRy0rdEkqroIHM4HWqDg9rH01Jk5z0 r84wo5ZUbCeNB2YM04GS0raARwSJmEJd0qPirI6FjYrdpiuTGw+L5xIStkBSSisj XDgv3ZHhVYAHL/iOW6RtSJr2cSOSOkYxQhb5A7LrLDVVaC0H5PznStn64jOcC1Z4 76b/od3crPyk1HdbsMmdNoGvedGJRJujQ92O6Ft2fee8xQenlGVL5EPYDZeIQlBA Jm3zFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cgPFEQykmhyZD2YLQ47aCJMzAxnB6OPQ1+SuXbXj7 LY=; b=QC/dgfLIpS4qTQxKdUxYPIm1f8Y1G6cpKbNBaxnjLDbafXpaGo0i/YFRk qgEaGIZb5hmrV88dqu0LHN3ftMDMxFkbo7LLIY8A1wcV4iBdqHEKXYKHUuZ7THSd dkKubALLjBE/1ll2lCdoXfq7gUNtLF99I3LH0bdDuQxqtqlu9fzxqc4J7an2HJbG L4BSXgf25/NKTf12iJrZGZFnbTQMuK4Pmi4RxiTkelmXXfWJY2krt4pT0LZ0LYsP aOdZ+ZCUwpSz8HW32jzGj+B59hrCdhKXbdqF/JdFSKxewsp8dGBQug9MoUQ9VAAh AkficvOlrpVRapHG3gg64My0qkMCQ== X-ME-Sender: <xms:S6HPXz7BVu0CGbbs4_C8MTuFPWGQMFrBmAxKn1ApKD5x0B4qnjJD3g> <xme:S6HPX44XrDD-g3zNnHmvfAwcys8Znrk7ZyahMk0xJPkMvQRdOtZs-SgR6cozl7LwU viRh22I8kPG_LGQyw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejiedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:S6HPX6fztyjYkygM3z8bpCxHWNH474gAfGCpQQoJeBYSkSDNqt_CpQ> <xmx:S6HPX0I0ElCyUJR9yW1GZLsPw0s2L-43JphctyfdtFIz_wNwtpMSsg> <xmx:S6HPX3JQzxfgnIDCbC1pfxpACFKn3un_sxTQ9ASgfxkMvZU8D4h1dA> <xmx:S6HPX5w-e5gD-EsdRKq3gMzl0ZsOcwGOZ1zKoo_0QZwnB_dA8IuBmw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C930D240062; Tue, 8 Dec 2020 10:52:42 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com> Date: Tue, 08 Dec 2020 16:52:41 +0100 Message-ID: <3329225.EJvk0WDFXs@thomas> In-Reply-To: <CAJFAV8yWe0WzLE6febVPe--Dir303=o_qxzcV6k0KQg=pWSCvw@mail.gmail.com> References: <20201207173319.1397740-1-thomas@monjalon.net> <CAJFAV8yWe0WzLE6febVPe--Dir303=o_qxzcV6k0KQg=pWSCvw@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 08/12/2020 16:37, David Marchand: > On Mon, Dec 7, 2020 at 6:33 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > When testing compilation and checking ABI compatibility, > > there is no real need of static binaries eating disks. > > The static linkage of applications are tested with GCC and Clang, > > plus some examples are statically linked. > > The after-installation build test is limited to "helloworld" example. > > Note the meson static build test was already limited to "l3fwd" example. > > > > The ABI compatibility is checked on shared libraries, so no need > > running this test a second time on builds intended for static linking. > > However, limiting ABI check to "shared builds" means all test cases > > must have a "shared build" occurence. > > As a consequence the 32-bit build test is switched to shared linking. > > I see no reason to tie the ABI check to default-library. The only reason is that ABI check triggers binary installation, which is big when statically linked. > What about the mingw target? ABI check is not required for Windows. BTW there are issues with DLL support. > What you want is to avoid doing duplicate ABI checks. > This happens for the gcc/clang x86 builds, so I'd rather control the > ABI checks out of the build() function (passing a new parameter?). Yes, it would be cleaner to separate ABI check requirement and static linking. In v2, ABI check will be enabled explicitly when calling "build" function for shared builds.