From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 20ACE7D4A for ; Thu, 25 Oct 2018 22:41:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9464221F11; Thu, 25 Oct 2018 16:41:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 16:41:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=no7KJnRUAE3vzVXrem2dAnYTWQmFvDtoeLUSY1ZOVuY=; b=nywN79GYbsbW jExPOWg+2ffzs+Z/ESxijukwi3DlP+VmFH7nTXqKujx4OfR1V92xLU/zKHtrppyU Ong/xKzxeMyPOt44ONYxVbnRrK36cw64InXc5Jc8BFxi7oEqVjenOeOIKrhxmmEN d7bKW3HeOFEzM+byaHqw3NvGPAhZDrs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=no7KJnRUAE3vzVXrem2dAnYTWQmFvDtoeLUSY1ZOV uY=; b=g/ItbqRE4jg7uiOkwbsIHeuhqiUwSPjIcnb3d8VHbcGt7NIJslaWk9app dS8+AnW8/3p+U0kZoH1xWUr4qan5hOV4IhrsrYk3e2NPrBE+De9UpSak5P7j/PAM Dh4w6cLpCBjUH3kGBsGBa8Tj+hXFFz5RK1g4xcEaZaPWLO3yQyVcD+FC8jtR9Cdu XiMI8LXLYkRbr3fsPe9iw1MoHoMtC9yvmq7QsFtpx5f5v+kJtcNL/yWoPjrJfmFv jI1xvUOuhHXsfgG9C1cczOxKc1P1lgEFiXlvGPlAofd9kcEdKufXa2bc0XSNNbf3 xy0K7KAKOaSyBdXfZvUmKYmPYV51Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF19F102A0; Thu, 25 Oct 2018 16:41:49 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com, Ciara Power , Brian Archbold Date: Thu, 25 Oct 2018 22:41:53 +0200 Message-ID: <3330387.zQnsHCFWfj@xps> In-Reply-To: <1665076.LlyA82DdBn@xps> References: <20181024132725.5142-1-kevin.laatz@intel.com> <20181024160311.85457-6-kevin.laatz@intel.com> <1665076.LlyA82DdBn@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 20:41:53 -0000 25/10/2018 22:29, Thomas Monjalon: > 24/10/2018 18:03, Kevin Laatz: > > --- a/lib/librte_telemetry/meson.build > > +++ b/lib/librte_telemetry/meson.build > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > > headers = files('rte_telemetry.h', 'rte_telemetry_internal.h') > > deps += ['metrics', 'ethdev'] > > cflags += '-DALLOW_EXPERIMENTAL_API' > > +jansson = cc.find_library('jansson', required: true) > > +ext_deps += jansson > > I just discovered an issue when trying to compile for arm64 > (with devtools/test-meson-builds.sh): > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-gnu/bin/ld: > cannot find -ljansson > > I am worried because it is a real blocker. The dependency must be optional. Should we disable the library if jansson is not found?