From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9A1D729B6 for ; Fri, 27 May 2016 16:43:53 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id n129so140305288wmn.1 for ; Fri, 27 May 2016 07:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKz365s9Lvaoxb1v0yD75sh0ehRTFOyi48psfLdm10M=; b=lVABVT8k3CEiwxnMg73ZFPOUH8mzS75KC+g7zEYnpSIJFjsSGV2xfPC/MExvHwby3y YKIytncO7cPp1PcZWpPW20V3xjkBpnpeM5+WnRYH0bLMSta7nTyE5LI5zuYo6hj86EKQ luVFQ9h9+9EXubzcDl3YmDfNerC8kguIG8DFCGYjHNDdwRMAmKdzClKcDEKGBoCRAPcW 1A4EfcVImfyZ67btSizNWYOtVgjjVR6bMpBSlaSXMDrhoClu8Pe4kDgA5No9pqRWKF+U lQe7yixKyjZwUA4itkWRdyke8Kx2D2+2/wjuST8ns7QHva4WC986PXcYqet638HR8941 bhtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BKz365s9Lvaoxb1v0yD75sh0ehRTFOyi48psfLdm10M=; b=as83riDf0xa8QmUNTU3ijymMt8ZbfDWR4KOBIf6rJyH396tsEnbUlW28rslTgm9LwO 5dHLcVpNiPJpcngKSAulOLk8V5mVrMSwIiJtFPpxaZ1Gxm4wOylae225j1NC9VQShSL1 39wkV2R4NKJo9BdWfkrmnqVYNAXH3l+50SECnF5Hf2I9Vh23x/FVxJI0J8Wc8kf/9oC7 heVAk8eMBDXd5kfJPmyuIeyE2Y1QIu/QKU39PsV5+b5dvrZlu66eWRpegD1etEKEwR6v YJOdcPACQBMSm7hRm1xqzS9lvall2SrvlMGpkYPqGVoGsEXA7bidlK+e5WH2bimjsDZe VNTg== X-Gm-Message-State: ALyK8tJGZuUSZhSMyYEiGloPadF0N83tHAN71ZPpDxJLRy0h01YR/aTU7Jtoq0EKszHgCwxq X-Received: by 10.28.54.204 with SMTP id y73mr9090891wmh.59.1464360233404; Fri, 27 May 2016 07:43:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jp2sm19722131wjc.16.2016.05.27.07.43.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 May 2016 07:43:52 -0700 (PDT) From: Thomas Monjalon To: Panu Matilainen Cc: zr@semihalf.com, remy.horton@intel.com, dev@dpdk.org Date: Fri, 27 May 2016 16:43:51 +0200 Message-ID: <3332485.q3f48ryagT@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1462963714-21022-1-git-send-email-zr@semihalf.com> <1464158214-24733-1-git-send-email-zr@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 14:43:53 -0000 2016-05-27 13:28, Panu Matilainen: > On 05/25/2016 09:36 AM, zr@semihalf.com wrote: > > @@ -1455,6 +1458,8 @@ struct eth_dev_ops { > > > > eth_get_reg_length_t get_reg_length; > > /**< Get # of registers */ > > + eth_get_reg_width_t get_reg_width; > > + /**< Get # of bytes in register */ > > eth_get_reg_t get_reg; > > /**< Get registers */ > > eth_get_eeprom_length_t get_eeprom_length; > > This is an ABI break, but maybe it is part of that "driver > implementation API" which is exempt from the ABI/API policies. Thomas? Yes dev_ops are for drivers, not for applications. Thus it should not be impacted by the ABI policy.