From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f180.google.com (mail-we0-f180.google.com
 [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 18D2858EE
 for <dev@dpdk.org>; Tue,  2 Sep 2014 16:16:53 +0200 (CEST)
Received: by mail-we0-f180.google.com with SMTP id w61so6991210wes.25
 for <dev@dpdk.org>; Tue, 02 Sep 2014 07:21:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=fEmoplTKxf4B+TiJoXexmDNZKUkLWyE00RoqaM7IDFs=;
 b=X9Lm08RfINuAkZWtQBIFzQUjgFjYOSc1L+cdQqLE2ehDKU9rRoLivhCxSOU4hwETLe
 F5/6Ws4XLlnHKplEN7GClI1RhM0CPIl/VXChVQSmEh0H/wH5DcCds1leuJIivqy6l9Lq
 gjp7PUWVuoRT8CdxpwyahNASWP7/eQiCHuhbpPF2UAYjGSdGwux06ZgJcN8AbL5UwGVU
 oxmyIo5nDyssG94RFNsA7r8P0uqoKobXtfEx39KR3yUyRIcaid3GvGf7J+dKqfx0HlrM
 X0kouvJwTymA/+nNTqDSl24pLmTDskGM20a4SdFDeAwINbGD2DlCzyQ+QILNRVVYaF/t
 CCgQ==
X-Gm-Message-State: ALoCoQk/TukLq0hkfn+P3dwTlzhV+SeYsjqaV4uWZgjj0VFTLE4U6x+syW0LVZcEIQEMQUbwE9RH
X-Received: by 10.180.184.20 with SMTP id eq20mr16207690wic.61.1409667685314; 
 Tue, 02 Sep 2014 07:21:25 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gr3sm35521370wib.12.2014.09.02.07.21.24
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 02 Sep 2014 07:21:24 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jay Rolette <rolette@infiniteio.com>
Date: Tue, 02 Sep 2014 16:21:18 +0200
Message-ID: <3333103.135tnuTvaT@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w@mail.gmail.com>
References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com>
 <CADNuJVpLLfiC_ROBkYQguHUGTgXNC1Bdu7HwveXcA23_Q3twxA@mail.gmail.com>
 <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Sep 2014 14:16:53 -0000

2014-09-02 16:16, David Marchand:
> >>  /* Macros to check for invlaid function pointers. */

Invlaid is an invalid word ;)

> >> -#define        FUNC_PTR_OR_ERR_RET(func, retval) do {             \
> >> -       if ((func) == NULL) {                              \
> >> -               DEBUGOUT("%s:%d function not supported\n", \
> >> -                       __func__, __LINE__);               \
> >> -               return (retval);                           \
> >> -       }                                                  \
> >> +#define        FUNC_PTR_OR_ERR_RET(func, retval) do {              \
> >> +       if ((func) == NULL) {                               \
> >> +               PMD_DRV_LOG("%s:%d function not supported", \
> >> +                           __func__, __LINE__);            \
> >> +               return retval;                            \
> >>
> > Need to keep the parens around retval in your macro
> 
> Actually, checkpatch complained about this.
> So I can keep the parenthesis, but then I don't want Thomas to tell me my
> patch does not pass checkpatch :-)

You're right, I care about checkpatch :)
I don't see a case where parens are needed with return. Please give an example.

-- 
Thomas