From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 1AFA75A9A for ; Thu, 4 Jun 2015 11:28:22 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so118319520wib.1 for ; Thu, 04 Jun 2015 02:28:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2mzAM00Yjpz7hDxNqrzKxahRot7+Cl1RBnSzuhtHnes=; b=T3un3tAiHd1bZtjA/TttX/9tYCBtsuzi5G7ncfCXP8tWKCtbyq6OWcShStyeF9VMt3 sws9JqKeYkv5+XIgWtNfbVqr/nXHQ98Ljm+vw0+gm3Wi0bsfphc6PpGSDVNYaabLX5W3 ZpqIgDW0FydnvnmiXMPOA4ctM7azBaJSiLoIsLA6Tn8NbSjkA2RaxwMc3jupFNsKfgGr aTWxCJN+mtcrj1ENpMDIM0MDn4PdSg8PEvJoFN6ZX1GSX6QtQRKSsJWHsAAiA2qeBtD2 SrqFG/GuuG2i5X1XEl9fAGqy8XpCldv5F7znk5VejOuGFPsxU3fO5dxmQ4FzZulwOGxZ VRwg== X-Gm-Message-State: ALoCoQnh0g6aGD52GHHmK714XETYRfAVJ5TeZpuiugJPTFDoXv6nLixw8Bp+YGrwH0sRBCdod6g9 X-Received: by 10.194.83.70 with SMTP id o6mr69470204wjy.44.1433410101955; Thu, 04 Jun 2015 02:28:21 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q2sm4858641wjz.15.2015.06.04.02.28.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 02:28:21 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Date: Thu, 04 Jun 2015 11:27:29 +0200 Message-ID: <33335664.AQckXK60Ox@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com> References: <1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 09:28:22 -0000 Hi Konstantin, 2015-06-04 00:10, Konstantin Ananyev: > This patch-set is based on: > [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT. > > Konstantin Ananyev (8): > ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK > ACL: code cleanup - use global RTE_LEN2MASK macro > ACL: add function to check rte_acl_build() input parameters > ACL: fix rebuilding a trie for subset of rules > ACL: introduce RTE_ACL_MASKLEN_TO_BITMASK macro > ACL: cleanup remove unused code from acl_bld.c > ACL: fix remove ambiguity between rules at UT > ACL: add new test-cases into UT Commit titles would be more useful if they shortly explain the goal instead of giving some function/macro names. It should be thought as a changelog entry and reflect behavioral change. On a side note, the keyword ACL: should be lowercase. In the case of fixes, adding a Fixes: line may help. It can be generated with this command: git log -1 --abbrev=12 --format='Fixes: %h ("%s")' Thanks