* [dpdk-dev] [PATCH v1] ci: update machine meson option to platform
@ 2021-10-04 12:55 Juraj Linkeš
2021-10-04 13:29 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
0 siblings, 1 reply; 5+ messages in thread
From: Juraj Linkeš @ 2021-10-04 12:55 UTC (permalink / raw)
To: thomas, david.marchand, aconole, maicolgabriel; +Cc: dev, Juraj Linkeš
The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute the same build which is now present in all DPDK versions the ABI
check verifies.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
.ci/linux-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 91e43a975b..f8710e3ad4 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -77,7 +77,7 @@ else
OPTS="$OPTS -Dexamples=all"
fi
-OPTS="$OPTS -Dmachine=default"
+OPTS="$OPTS -platform=generic"
OPTS="$OPTS --default-library=$DEF_LIB"
OPTS="$OPTS --buildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] ci: update machine meson option to platform
2021-10-04 12:55 [dpdk-dev] [PATCH v1] ci: update machine meson option to platform Juraj Linkeš
@ 2021-10-04 13:29 ` Juraj Linkeš
2021-10-11 13:40 ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
0 siblings, 1 reply; 5+ messages in thread
From: Juraj Linkeš @ 2021-10-04 13:29 UTC (permalink / raw)
To: thomas, david.marchand, aconole, maicolgabriel; +Cc: dev, Juraj Linkeš
The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute the same build which is now present in all DPDK versions the ABI
check verifies.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
.ci/linux-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 91e43a975b..06aaa79100 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -77,7 +77,7 @@ else
OPTS="$OPTS -Dexamples=all"
fi
-OPTS="$OPTS -Dmachine=default"
+OPTS="$OPTS -Dplatform=generic"
OPTS="$OPTS --default-library=$DEF_LIB"
OPTS="$OPTS --buildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v3] ci: update machine meson option to platform
2021-10-04 13:29 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
@ 2021-10-11 13:40 ` Juraj Linkeš
2021-10-14 12:26 ` Aaron Conole
0 siblings, 1 reply; 5+ messages in thread
From: Juraj Linkeš @ 2021-10-11 13:40 UTC (permalink / raw)
To: thomas, david.marchand, aconole, maicolgabriel; +Cc: dev, Juraj Linkeš
The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute the same build which is now present in all DPDK versions the ABI
check verifies.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
v3: ci retest
---
.ci/linux-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 91e43a975b..06aaa79100 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -77,7 +77,7 @@ else
OPTS="$OPTS -Dexamples=all"
fi
-OPTS="$OPTS -Dmachine=default"
+OPTS="$OPTS -Dplatform=generic"
OPTS="$OPTS --default-library=$DEF_LIB"
OPTS="$OPTS --buildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v3] ci: update machine meson option to platform
2021-10-11 13:40 ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
@ 2021-10-14 12:26 ` Aaron Conole
2021-10-25 15:42 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Aaron Conole @ 2021-10-14 12:26 UTC (permalink / raw)
To: Juraj Linkeš
Cc: thomas, david.marchand, maicolgabriel, dev, ohilyard, ci
Juraj Linkeš <juraj.linkes@pantheon.tech> writes:
> The way we're building DPDK in CI, with -Dmachine=default, has not been
> updated when the option got replaced to preserve a backwards-complatible
> build call to facilitate ABI verification between DPDK versions. Update
> the call to use -Dplatform=generic, which is the most up to date way to
> execute the same build which is now present in all DPDK versions the ABI
> check verifies.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>
Looks like something didn't go well in the UNH environment w.r.t. the
windows compilation for this patch. CC'd the CI list to take a look.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v3] ci: update machine meson option to platform
2021-10-14 12:26 ` Aaron Conole
@ 2021-10-25 15:42 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-10-25 15:42 UTC (permalink / raw)
To: Juraj Linkeš
Cc: dev, david.marchand, maicolgabriel, ohilyard, ci, Aaron Conole
14/10/2021 14:26, Aaron Conole:
> Juraj Linkeš <juraj.linkes@pantheon.tech> writes:
>
> > The way we're building DPDK in CI, with -Dmachine=default, has not been
> > updated when the option got replaced to preserve a backwards-complatible
> > build call to facilitate ABI verification between DPDK versions. Update
> > the call to use -Dplatform=generic, which is the most up to date way to
> > execute the same build which is now present in all DPDK versions the ABI
> > check verifies.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
>
> Acked-by: Aaron Conole <aconole@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-25 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 12:55 [dpdk-dev] [PATCH v1] ci: update machine meson option to platform Juraj Linkeš
2021-10-04 13:29 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
2021-10-11 13:40 ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
2021-10-14 12:26 ` Aaron Conole
2021-10-25 15:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).