Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/19/2021 1:40 PM, oulijun wrote:
> 
> 
> 在 2021/4/19 11:11, Li, Xiaoyun 写道:
>> Hi
>>
>>> -----Original Message-----
>>> From: Lijun Ou <oulijun@huawei.com>
>>> Sent: Monday, April 12, 2021 21:13
>>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
>>> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; dev@dpdk.org;
>>> linuxarm@openeuler.org
>>> Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd
>>>
>>> From: Chengwen Feng <fengchengwen@huawei.com>
>>>
>>> This patch support tx_done_cleanup command:
>>> tx_done_cleanup port (port_id) (queue_id) (free_cnt)
>>>
>>> Users must make sure there are no concurrent access to the same Tx queue (like
>>> rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command
>>> executed.
>>>
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>
>> As I remember, last comments (from Ferruh and Aaron) suggest you to do this in 
>> an unit test not testpmd.
>>
> Hi, Xiaoyun
> Maybe it is. We've tested it in our local environment and he's OK.If I use the 
> community's method of unit testing, I may have trouble doing unit testing. Would 
> you consider someone else to help me?
> I've already sent V4 and reverted to V3 and used the latest queue state solution.
> 

I think it is OK to have the testpmd command (this patch), at least makes the 
'rte_eth_tx_done_cleanup()' API used, but I believe this is not the best/easiest 
way to verify relevant PMD implementation.


For long term though we should have the 'app/test/test_ethdev.c' and improve it 
gradually and collectively.

>>> ---
>>> V2->V3:
>>> - The command implementation is changed so that the queuestate does
>>>    not depend on the command execution.
>>>
>>> V1->V2:
>>> - use Tx instead of TX
>>> - add note in doc
>>> ---
>>>   app/test-pmd/cmdline.c                      | 85 +++++++++++++++++++++++++++++
>>>   doc/guides/rel_notes/release_21_05.rst      |  2 +
>>>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ++++
>>>   3 files changed, 98 insertions(+)
>> <snip>
>>> +
>>>   show config
>>>   ~~~~~~~~~~~
>>>
>>> -- 
>>> 2.7.4
>>
>> .
>>