From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B14FA0524; Mon, 19 Apr 2021 16:56:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E01E4130F; Mon, 19 Apr 2021 16:56:50 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C1773412E6 for ; Mon, 19 Apr 2021 16:56:48 +0200 (CEST) IronPort-SDR: +G49crCRr1BVS67q8C4kLryIatcavFiDzI0uB3By0I+/hrB/bkysIIjQKVY2ruxb54bENKcJTE HJyFUzgPOFKw== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="215918405" X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="215918405" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 07:56:47 -0700 IronPort-SDR: T2X/gQDX5MU3b5hle9V+W6G/ocFMuHqwT5mPPz94D+kZgLCG3Qj0ye09TvW99ORq2l5MB60eDY rN4agLZ1ShRw== X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="462765175" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.224]) ([10.213.220.224]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 07:56:46 -0700 To: oulijun , "Li, Xiaoyun" Cc: "dev@dpdk.org" , "linuxarm@openeuler.org" , Aaron Conole , Thomas Monjalon , Andrew Rybchenko References: <1614938252-62955-1-git-send-email-oulijun@huawei.com> <1618233177-50822-1-git-send-email-oulijun@huawei.com> <9efc877e-ab4a-2b1c-8423-daf714fbd323@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <33403455-8873-3d8d-ccc5-2e6c8c7651e2@intel.com> Date: Mon, 19 Apr 2021 15:56:42 +0100 MIME-Version: 1.0 In-Reply-To: <9efc877e-ab4a-2b1c-8423-daf714fbd323@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/19/2021 1:40 PM, oulijun wrote: > > > 在 2021/4/19 11:11, Li, Xiaoyun 写道: >> Hi >> >>> -----Original Message----- >>> From: Lijun Ou >>> Sent: Monday, April 12, 2021 21:13 >>> To: Yigit, Ferruh >>> Cc: Li, Xiaoyun ; dev@dpdk.org; >>> linuxarm@openeuler.org >>> Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd >>> >>> From: Chengwen Feng >>> >>> This patch support tx_done_cleanup command: >>> tx_done_cleanup port (port_id) (queue_id) (free_cnt) >>> >>> Users must make sure there are no concurrent access to the same Tx queue (like >>> rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command >>> executed. >>> >>> Signed-off-by: Chengwen Feng >>> Signed-off-by: Lijun Ou >> >> As I remember, last comments (from Ferruh and Aaron) suggest you to do this in >> an unit test not testpmd. >> > Hi, Xiaoyun > Maybe it is. We've tested it in our local environment and he's OK.If I use the > community's method of unit testing, I may have trouble doing unit testing. Would > you consider someone else to help me? > I've already sent V4 and reverted to V3 and used the latest queue state solution. > I think it is OK to have the testpmd command (this patch), at least makes the 'rte_eth_tx_done_cleanup()' API used, but I believe this is not the best/easiest way to verify relevant PMD implementation. For long term though we should have the 'app/test/test_ethdev.c' and improve it gradually and collectively. >>> --- >>> V2->V3: >>> - The command implementation is changed so that the queuestate does >>>    not depend on the command execution. >>> >>> V1->V2: >>> - use Tx instead of TX >>> - add note in doc >>> --- >>>   app/test-pmd/cmdline.c                      | 85 +++++++++++++++++++++++++++++ >>>   doc/guides/rel_notes/release_21_05.rst      |  2 + >>>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ++++ >>>   3 files changed, 98 insertions(+) >> >>> + >>>   show config >>>   ~~~~~~~~~~~ >>> >>> -- >>> 2.7.4 >> >> . >>