* [dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag
@ 2018-07-03 18:44 Ferruh Yigit
2018-07-10 13:43 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-07-03 18:44 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, Ferruh Yigit
If "--disable-crc-strip" testpmd parameter issued, it removes the
DEV_RX_OFFLOAD_CRC_STRIP flag.
With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this
flag also should be set when this parameter issued.
Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
app/test-pmd/parameters.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 75807623c..962fad789 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -878,8 +878,10 @@ launch_args_parse(int argc, char** argv)
" must be >= 0\n", n);
}
#endif
- if (!strcmp(lgopts[opt_idx].name, "disable-crc-strip"))
+ if (!strcmp(lgopts[opt_idx].name, "disable-crc-strip")) {
rx_offloads &= ~DEV_RX_OFFLOAD_CRC_STRIP;
+ rx_offloads |= DEV_RX_OFFLOAD_KEEP_CRC;
+ }
if (!strcmp(lgopts[opt_idx].name, "enable-lro"))
rx_offloads |= DEV_RX_OFFLOAD_TCP_LRO;
if (!strcmp(lgopts[opt_idx].name, "enable-scatter"))
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag
2018-07-03 18:44 [dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag Ferruh Yigit
@ 2018-07-10 13:43 ` Iremonger, Bernard
2018-07-15 22:33 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2018-07-10 13:43 UTC (permalink / raw)
To: Yigit, Ferruh, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, July 3, 2018 7:45 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] app/testpmd: set keep CRC offload flag
>
> If "--disable-crc-strip" testpmd parameter issued, it removes the
> DEV_RX_OFFLOAD_CRC_STRIP flag.
> With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag
> also should be set when this parameter issued.
>
> Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag
2018-07-10 13:43 ` Iremonger, Bernard
@ 2018-07-15 22:33 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-07-15 22:33 UTC (permalink / raw)
To: Yigit, Ferruh; +Cc: dev, Iremonger, Bernard, Lu, Wenzhuo, Wu, Jingjing
10/07/2018 15:43, Iremonger, Bernard:
> From: Yigit, Ferruh
> > If "--disable-crc-strip" testpmd parameter issued, it removes the
> > DEV_RX_OFFLOAD_CRC_STRIP flag.
> > With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag
> > also should be set when this parameter issued.
> >
> > Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-15 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-03 18:44 [dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag Ferruh Yigit
2018-07-10 13:43 ` Iremonger, Bernard
2018-07-15 22:33 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).