From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95826A04BC; Fri, 9 Oct 2020 10:28:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 575411C1E8; Fri, 9 Oct 2020 10:28:39 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 855B41C1CC for ; Fri, 9 Oct 2020 10:28:36 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 5E1EE7AB; Fri, 9 Oct 2020 04:28:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 09 Oct 2020 04:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= hdY4KdXChF/gm3xejN5kLxY4u/hJaiwz/kdxJ+yvE8k=; b=tkpftSXV5El9IGmT F0zcVyLj+AAUzbEEUCrR0OS8yyannX3VMPz/tKS33cDiyvWORN1qItoyv0AwCTi+ OZyffKOll35oybgVJcuq0gE27oyHCm6egzqfnYjIJRWbuhIJL/HBN2gl23gbjJAh zCunZy6TWoY3Y753yHkSfZ8/vCwlkdW1INw/Mv/jQFCF7bGp9VusddBp9uAR5mSx eIkXwtdS2cx0dfkmtzvXM5/yoLJ0TpPWQ7ZMWpJga2LxOatCCQrByIuYb830hRtY de2Rayw5JFhwBgZRvWZthOrp4E1AkGUjYWg8e8r/nlR4NM+eeHi/EwDHmdV7P8Ay KMp8mA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hdY4KdXChF/gm3xejN5kLxY4u/hJaiwz/kdxJ+yvE 8k=; b=Xjk+u1r/kpxSkvCD5AaECEryZOU2QUP+sfCB/xOs1aySppmWk5iu+FLIt 2gjtMHSdDgS6jNS9Tz8Ju+Y0iSbOFZS5cLku0yu0k4ExxOLZl59vMRKb6zTKX/li iprlvVbpXohzkPbJmpHC/QeXpe00+DW5FMgQ5IAUehLXbXhRIbZfdoBCbvsP2bIg iGRG+oOhS+rX9FrAd+tXe0QsNI6ey+dY6cZZVVWsslAO4h/45iqp3A6nrobHtaU7 mjI+0Kvnm1x5VszDPAmaVa1ZGj8QQCItOEynzcl5foZ3zNMoU9jNWFsNOEgzPOyL mCP27T1spRrcBIOD93CEUrFtX+WBQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrhedugddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 251A9328005E; Fri, 9 Oct 2020 04:28:33 -0400 (EDT) From: Thomas Monjalon To: jasvinder.singh@intel.com, savinay.dharmappa@intel.com Cc: cristian.dumitrescu@intel.com, dev@dpdk.org Date: Fri, 09 Oct 2020 10:28:32 +0200 Message-ID: <3346037.l2is1eoJUd@thomas> In-Reply-To: <20201007140915.19491-9-savinay.dharmappa@intel.com> References: <20201006180233.15793-1-savinay.dharmappa@intel.com> <20201007140915.19491-1-savinay.dharmappa@intel.com> <20201007140915.19491-9-savinay.dharmappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 8/8] sched: remove redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > Remove redundant data structure fields references from > functions and subport level data structures. It also > update the release and deprecation note > > Signed-off-by: Savinay Dharmappa > --- > > doc/guides/rel_notes/deprecation.rst | 6 ---- > doc/guides/rel_notes/release_20_11.rst | 1 + > lib/librte_sched/rte_sched.c | 42 ++------------------------ > lib/librte_sched/rte_sched.h | 12 -------- I wonder why this patch exists. Documentation updates should be done when adding the feature (patch 3). Please try to conform to the release notes format and recommendations. Redundant code should be removed when it becomes useless. Or should it be last because the fields are used in apps? Anyway it is strange that a test for params->qsize is added. About the API changes, please update the ABI section of the release notes in each patch removing some old API.