From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5C35E1B6FF for ; Tue, 24 Oct 2017 02:11:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DA8FD201D0; Mon, 23 Oct 2017 20:11:34 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 20:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=7DDNxDPOfmmujR3sDOTn7np6Dh X8G3iwd8s/Haki2MU=; b=MAlgYf/ZJRdAjZTGXmItpGYk4fZITmQHOAaeWgr3Pi MAb3pVNOYV3oU2sv5I3hdhDOec8fbzp85bd28tdyh8Qb9eal6czZNOWU85gnYQcR eMf+rZbEqinuQO84xWtieSw6SoM1ExldHXzdRMgLrtcWz4OAQwIpWgcCjwfjcU4k M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7DDNxD POfmmujR3sDOTn7np6DhX8G3iwd8s/Haki2MU=; b=DQc12kOKeHoQ2AIWrLLrz1 c5lUn3KzdcXnjKvoRb85XD7MoniBovH9AQFsMwQbFnSa1olKpo5ZZ4QHD4LuYHaZ D2yVELvZosQfQeNFjffPXEowqzfjB8z+TwaX72rIF5DgchPDBW2yBaQJI/S5XfTE Zub+l1oCdvUU3BTlAXsadsDYWl2pXAWFPC3Awt1HLPiwYWfPmneeirX5k1j9MZhx ja1sgN5MYhluoKPd7B4ncsd8YUkNRaA7XYrdexfOX/j1Z6zyRKvJdEwHL5VDiIIY l5p3ai/iCpOSfXnXy4gc0KCdYq7M54ILXOsESrMIXwqWDWl9kuifYDvl99Eq+igw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 89DDA247A8; Mon, 23 Oct 2017 20:11:34 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, gage.eads@intel.com, santosh.shukla@caviumnetworks.com, bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com Date: Tue, 24 Oct 2017 02:11:33 +0200 Message-ID: <33542091.69SN6enjHd@xps> In-Reply-To: <20171012160421.8337-4-olivier.matz@6wind.com> References: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com> <20171012160421.8337-1-olivier.matz@6wind.com> <20171012160421.8337-4-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] mk: do not generate LDLIBS from directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 00:11:35 -0000 12/10/2017 18:04, Olivier Matz: > The list of libraries in LDLIBS was generated from the DEPDIRS-xyz > variable. This is valid when the subdirectory name match the library > name, but it's not always the case, especially for PMDs. > > The patches removes this feature and explicitly adds the proper > libraries in LDLIBS. Some DEPDIRS are defined in conditionals. The same conditionals must be used for LDLIBS. See 2 fixes below: > --- a/lib/librte_port/Makefile > +++ b/lib/librte_port/Makefile > @@ -38,6 +38,8 @@ LIB = librte_port.a > ifeq ($(CONFIG_RTE_PORT_PCAP),y) > LDLIBS += -lpcap > endif > +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev > +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_kni +LDLIBS += -lrte_ip_frag -lrte_sched +ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) +LDLIBS += -lrte_kni +endif > --- a/lib/librte_table/Makefile > +++ b/lib/librte_table/Makefile > @@ -38,6 +38,8 @@ LIB = librte_table.a > > CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_port > +LDLIBS += -lrte_lpm -lrte_hash -lrte_acl +LDLIBS += -lrte_lpm -lrte_hash +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) +LDLIBS += -lrte_acl +endif