From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id ED5BD5942 for ; Thu, 28 Aug 2014 16:16:50 +0200 (CEST) Received: by mail-wg0-f52.google.com with SMTP id m15so818569wgh.11 for ; Thu, 28 Aug 2014 07:21:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=STS2YKAEJioHF/t1FJcbSMYeIBytIo7pWCkVAJbFOJM=; b=hM5ZD5sMv92BmGiVy4ewdBDAfvD85Q3PqfrNq99LZRKQNT5abbM5OuJ3Oz/cbkvNxl o5Rci84eVmMfxhO8XMS85fTxyjc+Hzp9t79xUcI/aFIsNP+uvBLRprtnW/M9aBWbE4nH wHHrBgJ+hky9TJcD/hvCiliMpq+5ml/3tNCyRahnm2KNmE1/U2GWMp/san+olVNend2o 6TmIBu2TvO+kHHlF29VC9CIAotmzliQt876lNUSROVIgSOXPiO/qMklRCGOx+58w3bZZ 9ci292HRnJWMtXGso+f5wbVWLCW4mR3a7MypRdY43CYCKd7Ii5Izj5O4lbd2xtGa44Dp S8UQ== X-Gm-Message-State: ALoCoQlU1ANI6Xr6RL7oinOxzRf/SnORlLEvwShdnrxCT62sTBflLU+ZNgWasr76v4z17lQQ6u0M X-Received: by 10.180.104.163 with SMTP id gf3mr37398074wib.24.1409235660131; Thu, 28 Aug 2014 07:21:00 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id la2sm10394442wjb.5.2014.08.28.07.20.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Aug 2014 07:20:59 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Date: Thu, 28 Aug 2014 16:20:54 +0200 Message-ID: <33553897.HNdRDVj5YS@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8ADC20D@SHSMSX104.ccr.corp.intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <1793573.SnjKVZ6loZ@xps13> <9BB6961774997848B5B42BEC655768F8ADC20D@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/7] ethdev: define new ethdev API rx_classification_filter_ctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 14:16:51 -0000 2014-08-28 13:39, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > I'm OK to change APIs but you should remove the old one, or at least, > > implement your new API in existing drivers to allow deprecation of the > > old API. > > I think it would help if you start by doing ixgbe work and then apply it > > to i40e. > > > > Yes, it will be perfect if we can use this new API to achieve flow director > setting all types of NICs. But the concern is downward compatibility. In this case, cleanup is more important than compatibility. > Users who is planning update DPDK version need to change their code > to adapt such changes. Yes, but we can keep deprecated function during 1 release. > That's why we choose a new API instead of modifying current APIs. And > Of course, the ideal plan is adding such XXX_ctl function in Ixgbe and > Igb to moving smoothly without removing current APIs. Yes > > I don't think flow director is a specific feature. We shouldn't have > > to care if port is i40e or ixgbe to setup flow director. > > Is it possible to have a common API and maybe an inheritance of the > > common structure with PMD specific fields? > > Yes, flow director is not a specific feature. Even ixgbe and i40 use the same > name. But the context and key have much difference. That's why I called it > specific. > > Yes, it's a good idea about an inheritance of the common structure. I think it > may support new NIC integration in future. We can do it with the new API > architecture. But the concern is still how to be compatible with old version. There is no compatibility blocker here. If we can keep deprecated functions a while, we'll do. Otherwise, just go with the new API. I prefer we concentrate on good design rather than on compatibility. Thanks -- Thomas