From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id DAE9A9A9F for ; Sun, 8 Mar 2015 22:21:24 +0100 (CET) Received: by wiwl15 with SMTP id l15so15526234wiw.4 for ; Sun, 08 Mar 2015 14:21:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RWYI2dzn/pBNROoNzZrBbrFkUbga+kTerSHd5TRAKuw=; b=e5cDHxVgeWCPMeG3pf3FtfTQ/HKmKOheq14dCe8e3j/1t5oeGWrPb08KtwP4ADixSg +BANUhIx4n4btmFf+wS0onioXUoeHrJvw9M2V6bDhF2rKcu34jGRfklllTeznFPEFE8q O9YKR706y4jpvB7yVkeyK+hxo34Wrgmi2ZFUYXqUhzAGnusyXuPn3AWauOE4kF4H1AYL h3hPOPB8poVZFABTiq5nN11NKiFbK1UxyOvcudN0QQygQopWcG/QoztEOajCAq1SuIPL wXdV8nhurdgDblyMzYhwZzfBpw1EULBUlvT19H6VzJLrUpxume31atCoVPIMR1Axksad rtqg== X-Gm-Message-State: ALoCoQnH0CYL7czo/oprIzXG5w1g7h2t2qY5foVUAkBNPQO6k1STSph+q04CIRphEa/P2ISLr+Fp X-Received: by 10.194.11.9 with SMTP id m9mr50930605wjb.82.1425849684697; Sun, 08 Mar 2015 14:21:24 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fa3sm12553121wib.17.2015.03.08.14.21.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2015 14:21:24 -0700 (PDT) From: Thomas Monjalon To: Vlad Zolotarov Date: Sun, 08 Mar 2015 22:20:50 +0100 Message-ID: <3355568.qkVtABOLMn@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425823498-30385-6-git-send-email-vladz@cloudius-systems.com> References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <1425823498-30385-6-git-send-email-vladz@cloudius-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 5/5] ixgbe: Add LRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2015 21:21:25 -0000 2015-03-08 16:04, Vlad Zolotarov: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -312,6 +312,9 @@ enum rte_eth_tx_mq_mode { > #define ETH_VMDQ_DCB_TX ETH_MQ_TX_VMDQ_DCB > #define ETH_DCB_TX ETH_MQ_TX_DCB > > +/* TODO: Remove this when DPDK version bumps up to 2.0.1 */ The last digit is reserved for maintenance. LRO should be merged in 2.1.0. By the way, why removing this macros when it's integrated? I think it would be a good idea to start using this kind of macro for new API. It's better than version checking because it supports backports. Opinion? > +#define RTE_ETHDEV_HAS_LRO_SUPPORT Is it the right location to define it? Is it better than defining it just above one of the new fields or at the beginning of the file? > + > /** > * A structure used to configure the RX features of an Ethernet port. > */ > @@ -320,14 +323,15 @@ struct rte_eth_rxmode { > enum rte_eth_rx_mq_mode mq_mode; > uint32_t max_rx_pkt_len; /**< Only used if jumbo_frame enabled. */ > uint16_t split_hdr_size; /**< hdr buf size (header_split enabled).*/ > - uint8_t header_split : 1, /**< Header Split enable. */ > + uint16_t header_split : 1, /**< Header Split enable. */ > hw_ip_checksum : 1, /**< IP/UDP/TCP checksum offload enable. */ > hw_vlan_filter : 1, /**< VLAN filter enable. */ > hw_vlan_strip : 1, /**< VLAN strip enable. */ > hw_vlan_extend : 1, /**< Extended VLAN enable. */ > jumbo_frame : 1, /**< Jumbo Frame Receipt enable. */ > hw_strip_crc : 1, /**< Enable CRC stripping by hardware. */ > - enable_scatter : 1; /**< Enable scatter packets rx handler */ > + enable_scatter : 1, /**< Enable scatter packets rx handler */ > + enable_lro : 1; /**< Enable LRO */ > }; > > /** > @@ -1515,6 +1519,7 @@ struct rte_eth_dev_data { > uint8_t port_id; /**< Device [external] port identifier. */ > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / OFF(0). */ > scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */ > + lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > dev_started : 1; /**< Device state: STARTED(1) / STOPPED(0). */ > };