From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 2373D594D for ; Wed, 23 Jul 2014 11:03:26 +0200 (CEST) Received: by mail-wi0-f180.google.com with SMTP id n3so1835357wiv.1 for ; Wed, 23 Jul 2014 02:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=yrSsNCMQIXCYYP9l6b2NoXena3AOOBGV3zbwJItbZaE=; b=bfoVynPR43Y0nzssmcd5ZotpNjG+tPS5wYpJPTVuowFwqypSW1uEb02Dc4f5O9KxX8 yINfgNN6NgMxU429/2hBgnpqldtJsvaN05cgWOKGO8SA36gVnHGTantFApdXiKR1I/76 2xucSifako4Yj7iwAiUKaKPMaCSudmN44kVAyYAsrOh2Ka5he1Ab3qJR2X988RSjm4yF DTB+2djjhjNjJUQrI3eGFrY/Aip/gFNV5PHiOtGX+pUGc8EzNWfAJ5/gA319rwcpg8zT NaC1U4KtJepKOjEn6+TYNOMnmc/CRQtib5J/dHyb/DI9DjWa4fqt959/UN6TxhEtvxg2 PJNA== X-Gm-Message-State: ALoCoQlFxWr6xMarLUE2Ao+EmG4c84hc8E1LleVbal+EV8+FRrdsa8/s1IPQG7gnDlk/4YH1x5SV X-Received: by 10.194.24.2 with SMTP id q2mr41043626wjf.91.1406106288887; Wed, 23 Jul 2014 02:04:48 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dn3sm6967563wib.12.2014.07.23.02.04.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jul 2014 02:04:48 -0700 (PDT) From: Thomas Monjalon To: Hiroshi Shimamoto Date: Wed, 23 Jul 2014 11:04:40 +0200 Message-ID: <3356411.EsFcTdggfg@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 09:03:26 -0000 2014-07-23 08:53, Hiroshi Shimamoto: > 2014-07-23 09:50, Thomas Monjalon: > > 2014-07-22 23:40, Hiroshi Shimamoto: > > > does anyone have interest in this functionality? > > > > > > I think this is important and useful. > > > Since we should care about core assignment to get high performance > > > and the master lcore thread is special in DPDK, we will want to > > > assign the master to the target core. > > > For example, with hyperthreading I'd like to make a pair of packet > > > processing threads into one physical core and separate the master > > > thread which does some management. > > > > Thank you for showing your interest. > > Does it mean you carefully reviewed this patch? In this case, I'd appreciate > > a note "Reviewed-by:". > > Not yet deeply, wait a bit, we're testing this patch in our application. > Will report if it works fine. > > By the way, we should add the same code into the BSD code, right? Right. I'd prefer to reduce the duplicated footprint and have more common code between BSD and Linux. But waiting this enhancement, we have to maintain the duplicated code for BSD. -- Thomas