From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD32DA0524; Tue, 13 Apr 2021 15:35:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBD66160FA9; Tue, 13 Apr 2021 15:35:58 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id B885D160B08 for ; Tue, 13 Apr 2021 15:35:56 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5DFF35C0113; Tue, 13 Apr 2021 09:35:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 13 Apr 2021 09:35:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= kRP7N1qgWlixs7Fz3JiX0n7Ybvo67k9gDf9epqZThYA=; b=Gmt+a/oA2knQ9w+7 BEh3+HwsdH+WWfZcBmVViem4srB4lL8NVNzRz6/1pczbLRdvccr6wN30jJ1QGhht mp/wC8xZIbBsXhFowK3c7FcEcJf8rzffRpbuI1ApsBA6Kv08XoVDfDg9ocwT9Ww9 +3AOUkmtf34XQP+sfHOQsiBlOE/KhNJJUbf+ULV6/ZFT8YMQc1AfqQIzqP2HSoFo 5Tjy/YgRPBM55NKdyAbyN6etRHljaos06yHWzt6+U0C8qtg6TIA/y75XUdrRnbWT mDNlVcb2ovbpGOYm8uOcAvyZvmJ5k+kdcJ6OydQeZ5cyc5M2NNkKQkmStPJ7AQVl 91wtLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kRP7N1qgWlixs7Fz3JiX0n7Ybvo67k9gDf9epqZTh YA=; b=RXNo/4s7RETqkPgH0upMBeyHCdDwLDxEzwMt1/Igz0Ng8Ic5dP7VmBeV5 gV8UrUCZTuXMG86WQfD0TIHR+qlT93tVfy0v8NJwDA6uVi9KfxArcz9vIYiPlI6v ydW3gPQXuX9+d5vyddZ10AWcOlFJT3WdcDhG/pRl6SBUVe+ikrAKtmNNO5F8709J 7U+GaZWFMClP/8Tp1FB2TZ+vb6PExJeF4/Q2R5T9uhg5ggTow9cQOcQv5drLbjFO RT2hRICZ80zFmivU+ng9HxNmUSRU8O2kvqEjNMNOKMH9GhRsRflqrsS43v4dRGB9 l6HbC0S3Pq17XrgM98Dk/XcBXwcrQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19AA61080063; Tue, 13 Apr 2021 09:35:55 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stephen@networkplumber.org, drc@linux.vnet.ibm.com Date: Tue, 13 Apr 2021 15:35:53 +0200 Message-ID: <3365684.9AJlD7vKmA@thomas> In-Reply-To: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/03/2021 05:26, Tyler Retzlaff: > --- a/lib/librte_eal/include/rte_common.h > +++ b/lib/librte_eal/include/rte_common.h > @@ -31,9 +31,11 @@ extern "C" { > #define typeof __typeof__ > #endif > > +#ifndef __cplusplus > #ifndef asm > #define asm __asm__ > #endif > +#endif Applied with this explanation: eal: do not redefine asm keyword in C++ C++ forbids redefining a keyword as a macro. The keyword asm is conditionally-supported and implementation defined, but it seems our best guess. In C, if asm does not exist, it is defined as __asm__ which is a GNU extension. One more question: Can we have a similar issue with typeof? I guess it works because typeof is not a keyword?