Re: [PATCH] vhost: fix FD entries cleanup

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 2/6/25 9:41 AM, Maxime Coquelin wrote:
> With the recent rework of the FD manager to use epoll,
> an error message is emitted with Vhost-user at FD entry
> removal:
> 
> ERR|VHOST_FDMAN: could not remove 102 fd from 101 epfd: No such file or directory
> 
> It occurs because the read callback closes the file
> descriptor before it is removed from the FD set.
> This patch defers the close() after the FD entry is removed
> from the set.
> 
> Fixes: 0e38b42bf61c ("vhost: manage FD with epoll")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>   lib/vhost/fd_man.c | 12 +++++++-----
>   lib/vhost/fd_man.h |  2 +-
>   lib/vhost/socket.c | 11 +++++------
>   lib/vhost/vduse.c  |  9 ++++-----
>   4 files changed, 17 insertions(+), 17 deletions(-)
> 

Applied to next-virtio/for-next-net.

Thanks,
Maxime