From: Thomas Monjalon <thomas@monjalon.net>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update sample actions support in mlx5 guide
Date: Fri, 12 Mar 2021 16:51:00 +0100 [thread overview]
Message-ID: <3366850.cbAAZaNDrF@thomas> (raw)
In-Reply-To: <BL0PR12MB2419B6DAB7E78AD6CD6DB50EC66F9@BL0PR12MB2419.namprd12.prod.outlook.com>
12/03/2021 10:44, Jiawei(Jonny) Wang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 09/03/2021 14:09, Jiawei Wang:
> > > + - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for
> > NIC Rx sampling/mirroring flow.
> >
> > "sample actions for NIC Rx sampling" is redundant.
> > I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring."
> >
>
> These actions are support in the sample action list, user also can add modify, decap , encap in the NIC RX flow;
> How about this:
>
> "For NIC RX flow with sample action, Supports [...] actions in the sample action list" ?
Another suggestion:
For NIC Rx flow, supports [...] in the sampling actions list.
> > > + - Supports ``RAW ENCAP``, ``Port ID`` as sample actions for E-Switch
> > mirroring (sample ratio = 1) flow.
> >
> > I suggest "Supports [...] actions for E-Switch flow mirroring."
> >
> > If lines are long, do not hesitate to start a new line after a punctuation.
> >
>
> Ok, I will split into two lines.
>
> Thanks.
next prev parent reply other threads:[~2021-03-12 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:09 Jiawei Wang
2021-03-09 13:39 ` Thomas Monjalon
2021-03-12 9:44 ` Jiawei(Jonny) Wang
2021-03-12 15:51 ` Thomas Monjalon [this message]
2021-03-15 2:10 ` [dpdk-dev] [PATCH v2] " Jiawei Wang
2021-03-16 15:18 ` [dpdk-dev] [PATCH v3] " Jiawei Wang
2021-03-17 16:15 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3366850.cbAAZaNDrF@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).