From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8476A0547; Fri, 12 Mar 2021 16:51:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7517A1608BB; Fri, 12 Mar 2021 16:51:06 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C19681608AD for ; Fri, 12 Mar 2021 16:51:04 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 253935C0181; Fri, 12 Mar 2021 10:51:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 12 Mar 2021 10:51:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= mr0a8++kwZoN3jvQ4c5FMDa501hm7KjPgNzgbp9cJC4=; b=JoG6IIq2JDWGR+3x CkKQev53JVkS8FthHayzwg1sU4s1nP4HHzD55dMuR+OtHY0Xo59P2sY7D5kHgYAV OdE30XmIHV76jr7WZh3Eh5xfgHpMmRs280oaxq+QCU5aiow0svwodkESXe81bKWE G4lihu1ETJmYdWr8fx+QElffD54SMJGKMACGE3v66Vwl7dk3+owCPQsRRZaaVa4z LAtOZzAGIFkOxnGWK0wbIcXNaKzYvYqBjhAfr3hUlGGK1QAhqOulI+22cxQyU/jo QUpp4RKtHZRF/9iE4Mkf+ak8707j9cpTyuzxYvoQehVM48Np12Iw9P0kjcp+XIOB ON4jPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=mr0a8++kwZoN3jvQ4c5FMDa501hm7KjPgNzgbp9cJ C4=; b=VoZtM+dw0F2WVvb2Vlmg7j/nTvg7+GZGNfujCz2jM4yhuCO6vfukIBMcU GJYnkf76HI9dpnKbbQIDICjQn6Cm3qJ9d7dFrMKxXNmUNXL6323+UHcO8OVmhcAF 1U1z/5AHKMM+7ddFoaQZLOxpe6NHUaua0QmE5jlnFQzyXZe4d/6fOzRElOScmaJU cJF9gfhPZHxK77Ku2QVkw2esoe2DZXuphYPEQ7UPB3I/jjnZM6+j+LTYUoq027GQ bsMx9HBAw//CUmok5xTEfv4bOeW9bb5uF8zpnx1WCk0WSz4gv6FwNrR3WAgHEgwc d1sNKz3zSwoXnVhNJlg2C8DvIwXOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvvddgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED627240057; Fri, 12 Mar 2021 10:51:02 -0500 (EST) From: Thomas Monjalon To: "Jiawei(Jonny) Wang" Cc: Slava Ovsiienko , Matan Azrad , Ori Kam , "dev@dpdk.org" , Raslan Darawsheh Date: Fri, 12 Mar 2021 16:51:00 +0100 Message-ID: <3366850.cbAAZaNDrF@thomas> In-Reply-To: References: <1615295394-9082-1-git-send-email-jiaweiw@nvidia.com> <1766444.7SRveqVd2B@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: update sample actions support in mlx5 guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/03/2021 10:44, Jiawei(Jonny) Wang: > From: Thomas Monjalon > > 09/03/2021 14:09, Jiawei Wang: > > > + - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for > > NIC Rx sampling/mirroring flow. > > > > "sample actions for NIC Rx sampling" is redundant. > > I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring." > > > > These actions are support in the sample action list, user also can add modify, decap , encap in the NIC RX flow; > How about this: > > "For NIC RX flow with sample action, Supports [...] actions in the sample action list" ? Another suggestion: For NIC Rx flow, supports [...] in the sampling actions list. > > > + - Supports ``RAW ENCAP``, ``Port ID`` as sample actions for E-Switch > > mirroring (sample ratio = 1) flow. > > > > I suggest "Supports [...] actions for E-Switch flow mirroring." > > > > If lines are long, do not hesitate to start a new line after a punctuation. > > > > Ok, I will split into two lines. > > Thanks.