From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 5FD421B1C3 for ; Wed, 11 Jul 2018 11:30:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 67CCF316; Wed, 11 Jul 2018 05:30:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Jul 2018 05:30:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rF5PFOiozQYYOI5xW3k8HVjBVz xKxmhaRjecbzJ3wjw=; b=cj8q8cUDf8Sxu6UIlEM5c9q+UrJfHiQKlYEnQ18SjJ SdnTpSkb88RFAroON8TMfuASM+0Ea02ecS/dByTwXHiI9JV45+oSBg1pWcRDwdm0 R0sYtvzeTSvpVLdKkRBeabNCtHiTtnFMsciTxQrmVeeSP0pqRufqy+UwhxLLlMym 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rF5PFO iozQYYOI5xW3k8HVjBVzxKxmhaRjecbzJ3wjw=; b=b4FCFyIQobL+fNCC+k0FqE moVi8d30RJQkVV46oST3zbzDsWtRhaiK1xlYy+GCH6nkMod3QzXwfRT3g7ccFZp1 CETWIje8MxkryOMU7obc6ISXuZyQxIPBQ0JePvfzeBf0MN3j8SiUgL7XcY6C8wQW C1m++qnG+Y21OUKFUE80pC3Pc/QGocYfnxujK9ao6imWlO1ggGwPLrsRun7SERhq 9Rb+4HKTCwZNK9MhPW19rFfXRiXfYVzIaBB1wqnmxNkF3BnxUbDY91FTZR+KCnxa maveaKAJwHrkiRXizs7JyTRoTThfsyIBoolzWmaJmqKDMucRwSaCT1GrUz7e13nQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5088BE45C9; Wed, 11 Jul 2018 05:30:34 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org Date: Wed, 11 Jul 2018 11:30:32 +0200 Message-ID: <3367029.O4eSh4CbOy@xps> In-Reply-To: <20180711084116.dbbou4vbbp2y5tcn@bidouze.vm.6wind.com> References: <2914659.2M3dPKUJVY@xps> <20180711084116.dbbou4vbbp2y5tcn@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 09:30:37 -0000 11/07/2018 10:41, Ga=EBtan Rivet: > > > + struct rte_bus *bus; /**< bus handle. */ > > > + struct rte_class *cls; /**< class handle. */ > >=20 > > "class" is more readable than "cls" > >=20 >=20 > I was thinking that maybe this could be a problem when trying to build > with C++. The EAL headers in DPDK are meant to be included in C++ apps, > I think ``class`` would be an issue then. Yes, right. So only options are "cls" or "devclass". Up to you. > If I'm mistaken, then sure, class is a better name.