* [dpdk-dev] [PATCH] examples/ntb: fix mempool ops setting issue
@ 2019-12-25 9:09 Xiaoyun Li
2020-01-20 9:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Xiaoyun Li @ 2019-12-25 9:09 UTC (permalink / raw)
To: jingjing.wu, omkar.maslekar, dev; +Cc: Xiaoyun Li, stable
Mempool ops may register in different order when compiling. The default
ops index is always zero but the wanted ops is ring_mp_mc. This patch
sets best mempool ops before generating mbuf pool to fix this issue.
Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
examples/ntb/ntb_fwd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
index c914256dd..17eedcf0b 100644
--- a/examples/ntb/ntb_fwd.c
+++ b/examples/ntb/ntb_fwd.c
@@ -19,6 +19,7 @@
#include <rte_lcore.h>
#include <rte_cycles.h>
#include <rte_pmd_ntb.h>
+#include <rte_mbuf_pool_ops.h>
/* Per-port statistics struct */
struct ntb_port_statistics {
@@ -1256,6 +1257,11 @@ ntb_mbuf_pool_create(uint16_t mbuf_seg_size, uint32_t nb_mbuf,
if (mp == NULL)
return NULL;
+ if (rte_mempool_set_ops_byname(mp, rte_mbuf_best_mempool_ops(), NULL)) {
+ printf("error setting mempool handler\n");
+ goto fail;
+ }
+
memset(&mbp_priv, 0, sizeof(mbp_priv));
mbp_priv.mbuf_data_room_size = mbuf_seg_size;
mbp_priv.mbuf_priv_size = 0;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ntb: fix mempool ops setting issue
2019-12-25 9:09 [dpdk-dev] [PATCH] examples/ntb: fix mempool ops setting issue Xiaoyun Li
@ 2020-01-20 9:36 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-01-20 9:36 UTC (permalink / raw)
To: Xiaoyun Li; +Cc: jingjing.wu, omkar.maslekar, dev, stable, stable
25/12/2019 10:09, Xiaoyun Li:
> Mempool ops may register in different order when compiling. The default
> ops index is always zero but the wanted ops is ring_mp_mc. This patch
> sets best mempool ops before generating mbuf pool to fix this issue.
>
> Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Not sure I understand the explanation, but
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-20 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-25 9:09 [dpdk-dev] [PATCH] examples/ntb: fix mempool ops setting issue Xiaoyun Li
2020-01-20 9:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).