From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59C91A0A02; Thu, 25 Mar 2021 08:56:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31C0F40693; Thu, 25 Mar 2021 08:56:10 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0D7934067B for ; Thu, 25 Mar 2021 08:56:07 +0100 (CET) IronPort-SDR: QYpzZ2/lyGLDEmyOXPZJyrNRFXZNwWOGUkSAnl/61HQi+lrVlAyky6/lob6GEQUCHo88OO10mv Wvczi7m5dJDA== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="170855609" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="170855609" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 00:56:07 -0700 IronPort-SDR: xKhylG7Zh/Vc9B6RTVhOPCmMJ1RxyTOTJJJg3sBSgmuTxLD4SdaY9dcGYQGR6Ef1eyJzx33tQj maxBtAuSZ0RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="376742508" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 25 Mar 2021 00:56:06 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 00:56:04 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 15:56:03 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Thu, 25 Mar 2021 15:56:02 +0800 From: "Zhang, Qi Z" To: "Coyle, David" , "Rong, Leyi" , "Lu, Wenzhuo" , "Xing, Beilei" CC: "dev@dpdk.org" , "Rong, Leyi" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 Thread-Index: AQHXGxF4GRW7GpdKeEWooP5/jags6KqSeBUAgAHqUMA= Date: Thu, 25 Mar 2021 07:56:02 +0000 Message-ID: <3368f0c0bc7846ad853d5b603872e6f4@intel.com> References: <20210317091756.11878-1-leyi.rong@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Coyle, David > Sent: Wednesday, March 24, 2021 6:41 PM > To: Rong, Leyi ; Zhang, Qi Z ;= Lu, > Wenzhuo ; Xing, Beilei > Cc: dev@dpdk.org; Rong, Leyi > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 >=20 > Hi Leyi >=20 > > -----Original Message----- > > From: dev On Behalf Of Leyi Rong > > Sent: Wednesday, March 17, 2021 9:18 AM > > To: Zhang, Qi Z ; Lu, Wenzhuo > > ; Xing, Beilei > > Cc: dev@dpdk.org; Rong, Leyi > > Subject: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 > > > > Fix pkt_len parsing when DEV_RX_OFFLOAD_KEEP_CRC is set in AVX512 > > path. > > > > Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") > > Fixes: 6df587028e57 ("net/iavf: enable AVX512 for flexible Rx") > > > > Signed-off-by: Leyi Rong > > --- > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > index 5cb4c7cda6..67184ae3f4 100644 > > --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > > @@ -380,7 +380,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct > > iavf_rx_queue *rxq, > > len4_7); > > __m512i mb4_7 =3D _mm512_shuffle_epi8(desc4_7, shuf_msk); > > > > -mb4_7 =3D _mm512_add_epi16(mb4_7, crc_adjust); > > +mb4_7 =3D _mm512_add_epi32(mb4_7, crc_adjust); > > /** > > * to get packet types, shift 64-bit values down 30 bits > > * and so ptype is in lower 8-bits in each @@ -411,7 +411,7 @@ > > _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq, len0_3); > > __m512i mb0_3 =3D _mm512_shuffle_epi8(desc0_3, shuf_msk); > > > > -mb0_3 =3D _mm512_add_epi16(mb0_3, crc_adjust); > > +mb0_3 =3D _mm512_add_epi32(mb0_3, crc_adjust); > > /* get the packet types */ > > const __m512i ptypes0_3 =3D _mm512_srli_epi64(desc0_3, 30); const > > __m256i ptypes2_3 =3D _mm512_extracti64x4_epi64(ptypes0_3, 1); @@ > -869,7 > > +869,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue > > *rxq, > > */ > > __m512i mb4_7 =3D _mm512_shuffle_epi8(raw_desc4_7, shuf_msk); > > > > -mb4_7 =3D _mm512_add_epi16(mb4_7, crc_adjust); > > +mb4_7 =3D _mm512_add_epi32(mb4_7, crc_adjust); > > /** > > * to get packet types, ptype is located in bit16-25 > > * of each 128bits > > @@ -898,7 +898,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct > > iavf_rx_queue *rxq, > > */ > > __m512i mb0_3 =3D _mm512_shuffle_epi8(raw_desc0_3, shuf_msk); > > > > -mb0_3 =3D _mm512_add_epi16(mb0_3, crc_adjust); > > +mb0_3 =3D _mm512_add_epi32(mb0_3, crc_adjust); > > /** > > * to get packet types, ptype is located in bit16-25 > > * of each 128bits > > -- > > 2.25.1 >=20 > This patch fixes the issue >=20 > Tested-by: David Coyle Applied to dpdk-next-net-intel Thanks Qi