From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D77DA0524; Fri, 8 Jan 2021 15:06:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AC6A140EB9; Fri, 8 Jan 2021 15:06:32 +0100 (CET) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by mails.dpdk.org (Postfix) with ESMTP id 0303D140E09 for ; Fri, 8 Jan 2021 15:06:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 0E6041B8B; Fri, 8 Jan 2021 09:06:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 08 Jan 2021 09:06:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= KeNG9Y3jqavbCSNukBCZgY+LJcWEdaVBwmXnbkMpw98=; b=LSuP++LsiUMFJaYd xeJWv7IgKdcjcuQNwFa+1cw6M+Jlf6oTjLYpIeipsySwIiu9HHHb7deG1KcE/x9M Y+GX3mua+3gzXsRFmSILKXiaNCC8nk2QA52GzF7ixRym6sgCRcexarm3le78RzWw 86uDoKTcA9JEpQCd0PC1ua77Z0yEruIg0AeHoaXNIKFRG9rEVTpdTvOONgAZYvkv UwiLUB6+2O0jiKP+Jw8A4YxYgupKOkTFUk7NiS8jExqLJ2KBlHRjH8xL2vjiOEOI 3Nddt8O9Kf62vXXU5HHuEuheQnO/WwqY0AKHA4gRP66udBjS5zOmQebXg6S7v8J/ GJ5FUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KeNG9Y3jqavbCSNukBCZgY+LJcWEdaVBwmXnbkMpw 98=; b=f59q0yo0xESSl7cHw60WV5K9Y9ntj8npyMOs4tN4RP/X9caK8jqKlUH2k qJGIQH0mNHsKRBfi35FNixv8sjae7eWxvJk9pyzKzeAwMMC4+9UbUnEQnxFW3r9U mlZmOPpFRyGAL1zBin+yF9BinERAzp451vmRx3c++J3X0Llvcm9+gzdulLnA+wKH YACKUK3Vmczs4yW3V1xyG88VUjkY+z7mMNkwzUx2QU9TGHO4xmusL4grJRcKaZ1s M0aGC5yf7qMMtL54QJVe+lZ8HNjoVzpqc9IsdzIYWV9A85nSq+v0dHxgvd+fw5kf 4mH6I/sBhUEco62367aJptXRj+j6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeggedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejfffhhfeghfetveffgeffteelveekhffghfefgedvleeuveet fffgudelvefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5BF01080057; Fri, 8 Jan 2021 09:06:25 -0500 (EST) From: Thomas Monjalon To: "Guo, Jia" , "Zhang, Qi Z" , Ferruh Yigit Cc: "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "getelson@nvidia.com" , Dodji Seketeli , ray.kinsella@intel.com Date: Fri, 08 Jan 2021 15:06:24 +0100 Message-ID: <3369453.mArGO5O6NO@thomas> In-Reply-To: <76ec1db3-b739-330b-97d9-d99fc9110328@intel.com> References: <20201216085854.7842-1-jia.guo@intel.com> <2191627.gY80Bp0Rq6@thomas> <76ec1db3-b739-330b-97d9-d99fc9110328@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/01/2021 11:43, Ferruh Yigit: > On 1/8/2021 10:23 AM, Thomas Monjalon wrote: > > 08/01/2021 10:22, Ferruh Yigit: > >> On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > >>> 07/01/2021 13:47, Zhang, Qi Z: > >>>> From: Thomas Monjalon > >>>>> 07/01/2021 10:32, Guo, Jia: > >>>>>> From: Thomas Monjalon > >>>>>>> Sorry, it is a nack. > >>>>>>> BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. > >>>> > >>>> Yes that may break the ABI but fortunately the checking-abi-compatibility tool shows negative :) , thanks Ferruh' s guide. > >>>> https://github.com/ferruhy/dpdk/actions/runs/468859673 > >>> > >>> That's very strange. An enum value is changed. > >>> Why it is not flagged by libabigail? > >> > >> As long as the enum values not sent to the application and kept within the > >> library, changing their values shouldn't be problem. > > > > But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h > > so it is exposed to the application. > > I think it is a case of ABI breakage. > > Yes it is exposed to the application. But in runtime does it exchanged between > library and application is the issue I think. > For this case it seems it is not, so not an ABI break. If I create a table of size RTE_TUNNEL_TYPE_MAX with DPDK 20.11, I will get an overflow when writing to the new ECPRI index. The question is: can I receive the ECPRI value dynamically from ethdev? If yes, it is an ABI breakage. But I cannot think of such case now.