From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 21C06376C for ; Tue, 8 Dec 2015 11:12:19 +0100 (CET) Received: by wmvv187 with SMTP id v187so206312394wmv.1 for ; Tue, 08 Dec 2015 02:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=bKKH3IplLAa8A/ydVrV5qeUQpr2or7Pl4N6Cb2oYF+s=; b=eKnve9DgR+UqTjuQ4FBnauZn1MLmWnB0QhgAlNvBjaFe9eAHs01y80SdmVuBDOC2P3 mmbITwRrKhxRZYFj6jjP9jnomY2OJInBlO1HQB0gfiNRzmSWAZUYLGG7kN6pZ2sc7FxC u2tihqtn+LKSn80TRWlePZPbCK/vtcSjo+kDYFFpn22RLhwNXAshqO9I6SBE3TTKhdAa BWB9RYYn0rJe7zmaq88Dn7Fs3br7lQ8Do/c8xNTu9ZOdtbbTWSLwMR2J56Z9wjG2yZhX RlYtXZPjIkRLbOnjhpcYRiNtyalvhByIlk9Q6+eW3uU7z8F6yTMRGkqjNBBK7BEv3TSl c+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bKKH3IplLAa8A/ydVrV5qeUQpr2or7Pl4N6Cb2oYF+s=; b=VZbfBU8mZrtHM5t0uUj8yQ5IceAM108NCgDx3Ki+n7TT/s4YCXkG68B5oMcwTsW5lx Adts1QqxilUCMutSznNkmhKst6jgDRGMaG56XdohkOya8RsKAYhZ2nMvTUkU0tG7oj05 UEVRQ++/28LNXay3m/5vV/6CyHzJvYjdMFqgR5xFN4ewtwlFgFiJ2nx0fR00pFClJKqY 9JGDxzmdhSVa5IOTg6qNvFS7UN13fSV7bWzZBT2lCJLtao2/IDECTpNUwpkIptEMHEym tgtUU1lsdOXlVwrABPCzFUsWypep5InulzO+4a7+5abMLx5XCzZWZ3xiGQWrHDQbU6hN ipPw== X-Gm-Message-State: ALoCoQlMIm8CTzxCOQuCnU574TMgfpL60RR4l6utkKffNkjJ2HKMzyGL6PZGn0eqQmtg5rJo1WMtCGUxljGzg1BgQZvVAizGSg== X-Received: by 10.28.175.135 with SMTP id y129mr3677237wme.24.1449569538966; Tue, 08 Dec 2015 02:12:18 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id 143sm20801886wmv.18.2015.12.08.02.12.17 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 02:12:18 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Tue, 08 Dec 2015 11:11:04 +0100 Message-ID: <33721268.SXJjAvgPEg@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com> References: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 10:12:19 -0000 Hi Panu, 2015-12-08 10:30, Panu Matilainen: > --- a/lib/librte_vhost/Makefile > +++ b/lib/librte_vhost/Makefile > @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user > else > CFLAGS += -I vhost_cuse -lfuse > LDFLAGS += -lfuse > +LDLIBS += -lfuse > endif > > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y) > LDFLAGS += -lnuma > +LDLIBS += -lnuma > endif It looks weird to have to declare the dependencies both in LDFLAGS and LDLIBS. What is the reason? Can we improve it?