From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06B4243214; Fri, 27 Oct 2023 11:04:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E81E0406BA; Fri, 27 Oct 2023 11:04:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0B45D40272 for ; Fri, 27 Oct 2023 11:04:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698397461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kB3swzs05BiCkN9Z81HzF6yCtnLLY0CW+uFI94HWFeg=; b=iVCSEIPSy7rPDX5MxcGt2loAVkRA0YRtPwuIQMlf8RQcLbqbe6kC+WUsXWY2P/TtfyuGtU 7aXcnfH/r81jijszQpFajw5Ho1OwN9AORpjWMutLd/zg5SD3HAEstDgz/XG1qZ8PKP0UQ2 Z+kMqqpUMEZpiCaWIhgpTxmImovqQvI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-pOFXlMMHNWKI3cpqWoF85A-1; Fri, 27 Oct 2023 05:04:20 -0400 X-MC-Unique: pOFXlMMHNWKI3cpqWoF85A-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-540e79ccf3cso1349333a12.3 for ; Fri, 27 Oct 2023 02:04:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698397459; x=1699002259; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kB3swzs05BiCkN9Z81HzF6yCtnLLY0CW+uFI94HWFeg=; b=cveZbhKL02/W66t38J+WtRkGXQfaCrj5u8d8WCTwH6/Md8x6TK9WqopViyyaZFBxw9 9ug1Z02nYSy1suG2M9qVMheGM6GhGugZxYhPBlGixBDUTjBt6AWelPUN7vqtfLf5P7MO aFrCDzHXaytz03TBc/lxLSzNuosLvpeTqkJmkoY44DD5cuaQlcTLwG9IemDfRWAK2zS2 FnHUbf+PKHe2jlDFa2RDBaE3OFMY99eshjijElb/gK3srrCoUtMMMyoFMko4BcwDSJAN G106odGgaCnF/UULCsi6iIaD/fMwW6sW7SDSYkyv0+adRGw0fkDdc8FY+04t5ZFHPwOk nxPQ== X-Gm-Message-State: AOJu0YwechqGlKzMNa2pPKjsswv42lEq1O3PN0SQdkpQjv+MWn7xYlHD cGjGuctOiOS4sc/SMhhSXa2gkgNiG3Q7FRHKER4vcBmwtohUr7p3O9ssRlitvyCJjsi+1u+jZzT Dhjk= X-Received: by 2002:a17:907:7293:b0:9c7:59d1:b2ce with SMTP id dt19-20020a170907729300b009c759d1b2cemr1305643ejc.5.1698397458947; Fri, 27 Oct 2023 02:04:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4Woo/1EFfQeSq+rfJig6pNCVNlYg09Ob4Lw6NTSgzKYyZ8l1eJgQNiTJGsCEtKjifhwhGNQ== X-Received: by 2002:a17:907:7293:b0:9c7:59d1:b2ce with SMTP id dt19-20020a170907729300b009c759d1b2cemr1305634ejc.5.1698397458670; Fri, 27 Oct 2023 02:04:18 -0700 (PDT) Received: from [172.16.2.75] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id ov30-20020a170906fc1e00b009ad829ed144sm865646ejb.130.2023.10.27.02.04.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Oct 2023 02:04:17 -0700 (PDT) From: Eelco Chaudron To: David Marchand Cc: dev@dpdk.org, Maxime Coquelin , Chenbo Xia Subject: Re: [PATCH 3/3] vhost: annotate virtqueue access checks Date: Fri, 27 Oct 2023 11:04:17 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <3376A045-381F-44BB-BA47-BAFB7C4757F6@redhat.com> In-Reply-To: <20231023095520.2864868-3-david.marchand@redhat.com> References: <20231023095520.2864868-1-david.marchand@redhat.com> <20231023095520.2864868-3-david.marchand@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23 Oct 2023, at 11:55, David Marchand wrote: > Modifying vq->access_ok should be done with a write lock taken. > Annotate vring_translate() and vring_invalidate() and add missing locks. > > Signed-off-by: David Marchand The changes look good to me. Acked-by: Eelco Chaudron