From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1596A00C5; Tue, 21 Jun 2022 13:18:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF9D54069C; Tue, 21 Jun 2022 13:18:18 +0200 (CEST) Received: from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr [144.122.171.43]) by mails.dpdk.org (Postfix) with ESMTP id 05F8940151; Tue, 21 Jun 2022 13:18:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id B809A2C666; Tue, 21 Jun 2022 14:18:15 +0300 (+03) X-Virus-Scanned: Debian amavisd-new at ceng.metu.edu.tr Received: from guvercin.ceng.metu.edu.tr ([127.0.0.1]) by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9tOzt3Hg0bHT; Tue, 21 Jun 2022 14:18:03 +0300 (+03) Received: from roundcube.ceng.metu.edu.tr (kanarya.ceng.metu.edu.tr [144.122.171.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: e1885458) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id AA1572C1B6; Tue, 21 Jun 2022 14:18:02 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr; s=mail; t=1655810283; bh=DNrHSMyP1MVAyHcD3GIWHkDPrB89ehie8ufWM05wjL0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zr2Ur1rdpJ4SqAckH+sK/OE/lej9X5+lYTKeZ+HJ+nlN0JrYS6AlD9Mc8OdSavB9J ZdmPBFPpBXk41pGQAHFQzWkuJjkC3eNH4nLkF6rXxTt/r+QYi1OeKLrQMoA0FjcHS2 spdjodl+mkTVcSTxv8KvI8oMXb9nk/9EwU9bcH6s= MIME-Version: 1.0 Date: Tue, 21 Jun 2022 14:18:02 +0300 From: Omer Yamac To: Ferruh Yigit Cc: "Hunt, David" , dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , David Marchand Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor In-Reply-To: References: <20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr> User-Agent: Roundcube Webmail Message-ID: <338164f32ff2c34fbd2e8c2dae22877e@ceng.metu.edu.tr> X-Sender: omer.yamac@ceng.metu.edu.tr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21.06.2022 13:26, Ferruh Yigit wrote: > On 6/21/2022 9:44 AM, Hunt, David wrote: >> >> Hi Ferruh, >> >> On 20/06/2022 18:10, Ferruh Yigit wrote: >>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: >>>> This patch fixes the syntax error when using the single-core >>>> for both rx and distributor functions. >>>> >>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Abdullah Ömer Yamaç >>> >>> Acked-by: Ferruh Yigit >>> >>> >>> Can we convert compile time macro to dynamic configuration to prevent >>> build errors like this? >> >> >> +1 for the dynamic config. Maybe a "-c" on the command line for >> "combine >> rx and dist threads"? >> > > Hi Dave, > > '-c' sounds good, > > Can you, or someone you delegate, address this, or should we create a > bugzilla to record? > > Or Omer if you are interested in doing this change, please let us know. Hi Ferruh, I can do it, if you can review it. Because I am trying to getting familiar of your coding style. > >> >> Tested-by: David Hunt >> >>