From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80269A04B6; Mon, 12 Oct 2020 23:53:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35CDF1D9D9; Mon, 12 Oct 2020 23:53:17 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id DFD551D9D7; Mon, 12 Oct 2020 23:53:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 7C0FD131F; Mon, 12 Oct 2020 17:53:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Oct 2020 17:53:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= UB1ahGncwvQvmgGzqqa99rE4m7sbEH+e0tx+CL9qdJ0=; b=AEP1X5E4ZbBcxeiF bOz6RaDzUoT53OjltV04uuFLnB6AgLDVsBdI3fGMf6Dyrm4DIjG9A1KvE/fhzEme 4J8V4xjx6cmGIOdYkcHiADNeENWO9AonAQ7nN6L8/EBEEd3TwxTDjExf4jo6rKs7 B+Ml3qIOELHOg4HrYesYxj7laGxb9t+UZXWp/0L325fvjxxuUeCqZTX1WjiNvlzs yM1ZB0zA2Fd3Vylh7i9kMji1X+3k25SW5eSRFX9zSkv15JH8uX8QNWl0Cmpe/WXt fHGX9Eh5V6hB1uAdl4iPxsHMaRFx6FWJpsgE4MxZZxTv6tdaBmh6qJhYWvE4IvT4 nOU0rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UB1ahGncwvQvmgGzqqa99rE4m7sbEH+e0tx+CL9qd J0=; b=HeP9jIXHUMEyD9AIZb8rsJTwF39T+K7Z7IcRd1JKigVLW3Lk13aGhJ4z9 qMTuqmJqwMu7MQtF/6jKJ76Q45c3Dy2DBLORLJEBYTlvTHRd1gdYqqJIBVm4P84o VwDBbKxuIbmx4Rn+Wwu/X0LM1sHLGKE7Snm1pkfpgSSpmHs/3HpuLwS2/lKBb6zZ mwpGS38whIAUd/Ffj1weIHPrBE8wT9SKEqgO/JmSPHzYw3Ibls5Z4EU379Llu0AC riMm07IUOlEVh/ibtyc6H2pLC4752ZfkS6jXAFB1WRJg1xPKfCaKqdloXpFABeKi okqHhKNQSS2MX/E++r0GR4+VM3m7Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheekgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 534DA3280059; Mon, 12 Oct 2020 17:53:09 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, techboard@dpdk.org, Min Hu Date: Mon, 12 Oct 2020 23:53:08 +0200 Message-ID: <3382071.xncihUvvZe@thomas> In-Reply-To: <20201012164602.1965694-1-ferruh.yigit@intel.com> References: <20201012164602.1965694-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/10/2020 18:46, Ferruh Yigit: > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the long term. > > Instead PMDs should represent the queue statistics via xstats, this > gives more flexibility on the number of the queues supported. Yes > Currently queue stats in the xstats are filled by ethdev layer, using "some basic" queue stats > the basic stats, when queue stats removed from basic stats the > responsibility to fill the relevant xstats will be pushed to the PMDs. > > During the switch period, a temporary > 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag is created. The PMDs > providing the queue stats in the xstats should set this flag to bypass > the relevant part in ethdev layer. > > When all PMDs switch to the xstats for the queue stats, queue stats > related fields from 'struct rte_eth_stats' will be removed, as well as > 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' flag. > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > removed. > > Signed-off-by: Ferruh Yigit > --- > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > +/** Device provides queue stats in xstats */ > +#define RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS 0x0040 Not exact wording here and in the title. We should try to convey the idea that the basic queue stats are not automatically converted from the array to some xstats. Something like RTE_ETH_DEV_NO_AUTOFILL_QUEUE_XSTATS Or we can define the opposite flag and set it by default in all drivers which fill the basic queue stats. I suggest RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS