From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12FE2A0597; Fri, 17 Apr 2020 18:10:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E7781E9C2; Fri, 17 Apr 2020 18:10:07 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 419511E9BF for ; Fri, 17 Apr 2020 18:10:06 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DC5F55C02AD; Fri, 17 Apr 2020 12:10:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 17 Apr 2020 12:10:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=HzItJHLiOv/hHQfSxvDGmbOqWsL0BL9psQMA1oCnYnY=; b=reRmtnNKh2tx e6ALG7Xso68ZUonzA46VsTtRRcScTYEmDgA2EQGD4CA3ElGtQSPl+P4wB/97h2vp Yj8R+BpW7K6NziWPRuNmoud4EC7ftbum31rTC7uXbQl6lqY/e2lLXKQgCdXbkxxC keDuLjwv2ANFRdyVrsQxZ8HcMrUET3I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HzItJHLiOv/hHQfSxvDGmbOqWsL0BL9psQMA1oCnY nY=; b=4Dck1mwRwBOUaHgIOqprlZR+43uDlR2qzJl5GVCDG67zkZDlcfNXnRQHF 1I/YDcuJ/qRS0pt2RsOTgyfVw1fCSTgJWCYfcUwUbaGZ5tp92hO63flI4DCTcvXA ivVo2vp7o41JpZciMwFPoVeNqyc4ihAuYBIAQToLJwMtX+3Yx7E17Qye38Edn5PP e/ASgOOC7tg+aoUYLv8bQNT3FSn3rvBaIC/nl3WX7GRzbIqonu1c9ow1Kzu9Bh1e OpXNEY1yZALVSQUv/s6RtufMXA92KycfLtpgcCNwidJMkAUliYYWUTvV21BYdTYo G9XwnqRhWpfZpsIyrAmcjChmH+s6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeejgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07C69328005D; Fri, 17 Apr 2020 12:10:02 -0400 (EDT) From: Thomas Monjalon To: Neil Horman , Ray Kinsella Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 17 Apr 2020 18:10:01 +0200 Message-ID: <33823472.ATrlOLLGV9@thomas> In-Reply-To: References: <20200416145414.262296-1-nhorman@tuxdriver.com> <7246510.17fYzF0512@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/04/2020 17:42, Ray Kinsella: > On 17/04/2020 13:10, Thomas Monjalon wrote: > > 17/04/2020 13:47, Ray Kinsella: > >> On 17/04/2020 11:20, Thomas Monjalon wrote: > >>> 17/04/2020 12:11, Ray Kinsella: > >>>> check-abi.sh appears to be backward step in terms of usability. > >>> > >>> No, check-abi.sh benefits from a nice integration in build scripts. > >>> See below. > >>> > >>>> With validate-abi.sh I do can do a "validate-abi.sh HEAD~1 HEAD". > >>>> And it will do the build, install, dump and comparison for me. > >>>> And it picked up my 20.0.2 - > 21.0 changes no problem. > >>>> > >>>> With check-abi on the other hand, I need to the build and install myself. > >>>> check-abi requires dump files, but I see no reference in the documentation to how these are created. > >>>> It silently fails when it doesn't find any ... > >>>> > >>>> Do I run abi-dumper on the so's myself, or how does it work? > >>> > >>> check-abi.sh is integrated in test-build.sh and test-meson-builds.sh. > >>> Probably we should document usage in these scripts. > >> > >> Looks like I need to set DPDK_ABI_REF_VERSION=master, not obvious. > >> Any tips or tricks would be welcome. > > > > export DPDK_ABI_REF_VERSION=v20.02 > > or > > export DPDK_ABI_REF_VERSION=v19.11 > > > > Depends on which compatibility you want to test... > > > > Few things ... > > 1. test-meson-build.sh keep barfing complaining about reference paths. > ValueError: dst_dir must be absolute, got reference/v19.11/build-gcc-static/usr/local/share/dpdk/examples/bbdev_app > > Under the hood, ninja install is failing complaining that it needs an absolute path. > I fixed this in test_meson_build.sh and will send a patch in a minute. > Though it's strange no-one else has seen it? I set an absolute path in DPDK_ABI_REF_DIR. Not sure you can really fix it. What would be the root dir? > 2. test-meson-build.sh compares the abi for the static builds, which doesn't make any sense. Yes > 3. test-meson-build.sh will only take a branch in DPDK_ABI_REF_VERSION that exists locally. > In order to get it to compare HEAD against HEAD~1, which you would imagine is a pretty common case. > I had a create a branch for HEAD~1, in validate-abi this a pretty simple `validate-abi HEAD~1 HEAD` Why is it a common case? You want to compare with a tag. Why something else?