From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AFF8023D; Wed, 25 Jul 2018 10:21:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5BBCD21CF9; Wed, 25 Jul 2018 04:21:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 25 Jul 2018 04:21:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=QuibQnN7wVYP4yjsgoTKbMKl7x 2YLm6+o/gr8nuZOR0=; b=nha6bxiSYaHimMIfiYpzC/z2raO710UFQuD+4xDP6S wn0aYpJw3ZfeJBPKtGUZvaxy7FhjDhuZXCvyGhNxZCplkw5lI1z7jllS0bM8aFmH GtvdJmafsI7wwOZFLVVJuOtIa8GEUspP0L1BIIwEsFrQ6GAXhUiBhIT+GN6LU3gX U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QuibQn N7wVYP4yjsgoTKbMKl7x2YLm6+o/gr8nuZOR0=; b=rWqB5GeCtCPjo8aTDsNMYm sTOMg0MIbqrKpCCenmL/EASvdjpPoHqM1HCk6IbskzqEAVA9qwSiHKtEW8+NRK5v B83g8DVuYNUO8EsQLxcv4/NoRQL1EKv1SOxT2FOTvXLwGZlNhXAoY0nMDuYu9XjH TzmvCf1Zm09+D4pyV2d04l9SnqP9RcsN7SDq/SVDVhueG4yE6luNDfNS1/TnoFwn R2QrSJCrDK1KUQGHOkfizXoKZvAQU/Pjgwn4I9IESYpBp1JbAVM8s8+MBs7qEL45 9Jw2apTaVFTMzpzWiIYczZFTmMiyHuxnbwRyDmmakFWEcv6HDjQCYLFK49XX/ogg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A38010285; Wed, 25 Jul 2018 04:21:30 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , Moti Haimovsky Cc: stable@dpdk.org, "dev@dpdk.org" , "Singh, Jasvinder" Date: Wed, 25 Jul 2018 10:21:25 +0200 Message-ID: <3391330.dETbu75WYu@xps> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E779325@IRSMSX107.ger.corp.intel.com> References: <1532449282-9352-1-git-send-email-motih@mellanox.com> <3EB4FA525960D640B5BDFFD6A3D891268E779325@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: workaround softnic CLI modifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 08:21:32 -0000 24/07/2018 19:39, Dumitrescu, Cristian: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Moti Haimovsky > > Sent: Tuesday, July 24, 2018 5:21 PM > > To: thomas@monjalon.net > > Cc: dev@dpdk.org; stable@dpdk.org; Moti Haimovsky > > > > Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI > > modifications > > > > This patch returns the previous testpmd command line handling > > routines (namely cmdline_interact and cmdline_stdin_exit) to the > > prompt routine in order to overcome testpmd abnormal exit observed on > > several setups. > > These routines will only by used when testpmd is compiled without > > support for RTE_LIBRTE_PMD_SOFTNIC > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: Moti Haimovsky > > --- > > app/test-pmd/cmdline.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > We should probably fix the issue in the cmdline library to bring cmdline_poll() on parity with cmdline_interact(), but this is a decent workaround to avoid breaking those automation scripts that rely on Ctrl+D behavior. This workaround works only when disabling softnic. It means: 1/ softnic usage is not fixed 2/ we need to disable softnic for all other usages I think it is not good enough.