From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id C4F7A5686 for ; Wed, 14 Jan 2015 17:37:51 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id ho1so3741030wib.0 for ; Wed, 14 Jan 2015 08:37:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HIaS+q4khwo/Rf09KbVIq/IyyxVMrr2p2x1o1ms7hcU=; b=GBZW2JBL2Y4WnvZ8h8F8RTDWINi9UXnhIyRL14/dm9riwh5Zhm4DH1znRyNt8osyUe MPH+ZHQ58YaiwkFwgOxaApeTaAX+/vQq8LDDXRRCjTbMSrUu0wXwpVqAc90gfvvJTjgA cm87LjhaGuOEQKfkKEjzbwPBPLWrN2Mo4pbrPW04Xn3IfehBm/4c5FZPJyUmpADJ5g/P p+Lz9AjR9BcgDlq3Cl8f8MAq0KvwQ3+RhhEKR/gm+IHAIsP9njUel72NOTVKbp+pAS52 JzgTOaf+3pF4MIhFHmjdieldfZdlj8+FCtzZm0yYhHaKuIdED+SqUfK2Ra505nHa+w6V xXmA== X-Gm-Message-State: ALoCoQlHddaWfVuAl6UyyzlxeiAx7oCbddjBZz36FyPUwYcnqsX2IFbXyqogPRpUdZzSF9ooNcOK X-Received: by 10.181.13.105 with SMTP id ex9mr17043903wid.69.1421253471599; Wed, 14 Jan 2015 08:37:51 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id h8sm4038787wiy.4.2015.01.14.08.37.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jan 2015 08:37:50 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 14 Jan 2015 17:37:28 +0100 Message-ID: <3392599.aeVbzi96HQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1408932572-10343-1-git-send-email-changchun.ouyang@intel.com> <1414381533-30370-4-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 16:37:51 -0000 Hi Huawei, 2015-01-08 10:07, Xie, Huawei: > CTRL_RX is dependent on CTRL_VQ. > CTRL_VQ should be enabled if CTRL_RX is enabled. > Observed that virtio-net driver will crash if CTRL_VQ isn't enabled in vhost-user case. > /* Caller should know better */ > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) || > (out + in > VIRTNET_SEND_COMMAND_SG_MAX)); Do you plan to send a patch? -- Thomas