From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7379BA04B1; Wed, 23 Sep 2020 18:40:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9DBB1D9CC; Wed, 23 Sep 2020 18:40:12 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 50A6A1D976 for ; Wed, 23 Sep 2020 18:40:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 78A4A5C022A; Wed, 23 Sep 2020 12:40:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 12:40:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= sfcpowEfSop+6dihRXg+uk+X+AjMu1w3/hJTqHDdBz0=; b=ZlezQd2BnYbHdeVX rsSL7v5Ys7VBv4uGRNlwqZvp+5vD1l6Iz9qD4Ip0dA1xnAKNZ3zPh7uWSaLb6Wh5 GWKUF805fJUhQ3PIVXDzkFBW3oSWenPVYv64bzYzeUzM8/w4jgUAS6EnINNMfht3 qnj3opVC+fum+JnJ5IUaZ81XbBbJ9OXt9q38uplSl07wcQm/8l55XY6eOybE8RU3 AjGr/Qm7dpF8C0OJ4SWO6atiqeKa43pYgBLwzb7pvF55hPj4Bel0ED+5FBUx248J bpMZFByx9IKNaQLqz0kEsGqNxPKbnzQiahTTr6JpQikT5K0+EoL2saJ3pK1yPeEL tov3VQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=sfcpowEfSop+6dihRXg+uk+X+AjMu1w3/hJTqHDdB z0=; b=YsZeZJENmLGAo9EuM6BA/b3tjdwwqdbfG0m0IVh4EsE6v13FRUIwHmQDC OqQ2qfGlJ7uArLWzvZcZ8gkze3LOWDRyZPNMCgD7eLgVY6G4Fl+IP1PNbrdflTIU g5F8BTktMfoUFOdw+tzpxgpzippD/S20j32r1Ii0TbwYQ25Wp02jK15a8B6hC7nJ IgwyzFFioUr2OAIPKErzEscJ+Nl/qnyQMNEwLD2h7xckR5ThoSK9P/YrUB+PIJFY Hebp7e/rkooxwl2w/Yhbx1S7OmWICzjIblkDUj4AxQzlGQVHSra0dFxPyx3oMswK emuSRVwl758r6eZrt6zkor5ks1jeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE0BF3280060; Wed, 23 Sep 2020 12:40:07 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , David Marchand Cc: dev Date: Wed, 23 Sep 2020 18:40:06 +0200 Message-ID: <3393138.8c1kj3NxaF@thomas> In-Reply-To: References: <20200908201830.74206-2-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/09/2020 18:28, David Marchand: > On Wed, Sep 23, 2020 at 6:08 PM Dumitrescu, Cristian > wrote: > > > - On the patch titles, check-git-log.sh reports: > > > Wrong headline case: > > > "pipeline: add SWX dma instruction": dma --> DMA > > > Wrong headline case: > > > "pipeline: add SWX rx and extract instructions": rx --> Rx > > > Wrong headline case: > > > "pipeline: add SWX tx and emit instructions": tx --> Tx > > > Wrong headline case: > > > "pipeline: introduce SWX xor instruction": xor --> XOR > > > > > > > I can do this change, but IMO it is not the right choice here, as in this particular case we have instructions that are called "rx", "tx", "dma", "and", "or", "xor", etc. So it is the name of an instruction rather than a text abbreviation. Hence, I think these messages are not really applicable here. What do you think? > > For this reason I am ok with ignoring too, Thomas wdyt? The general idea of titles is to not use exact same wording as in code (no function or variable names for instance). For the instructions, I don't know. If you think it is better as lowercase, I can be convinced.