Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

[Thomas Monjalon <thomas@monjalon.net>]

27/03/2018 15:59, Anatoly Burakov:
> Under the hood, we create a separate thread to deal with replies to
> asynchronous requests, that will just wait to be notified by the
> main thread, or woken up on a timer.

I really don't like that a library is creating a thread.
We don't even know where the thread is created (which core).
Can it be a rte_service? or in the interrupt thread?


> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -225,6 +225,7 @@ EXPERIMENTAL {
>  	rte_mp_action_unregister;
>  	rte_mp_sendmsg;
>  	rte_mp_request;
> +	rte_mp_request_async;

So there is rte_mp_request and rte_mp_request_async?
You should rename rte_mp_request, I guess.

>  	rte_mp_reply;
>  	rte_service_attr_get;
>  	rte_service_attr_reset_all;