From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 7F9DE44CF for ; Tue, 27 Mar 2018 18:34:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1CDB92133A; Tue, 27 Mar 2018 12:34:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 27 Mar 2018 12:34:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=s6jzdxbU2fUmcGx42nvorjMaOH 4Pg84gQ7Pwx5KTSvc=; b=fif5AqCs2dj3TquFu4Kanw5iRrJvtMYxEFirEzyy9X H7/EiwTekEoZMp5RgxkbKoSblT2AyxgTcDnInieRqe5wL9DSeq1eGBnbE47asfP6 zMcLo2t51USQwiK889M57VcRIt2HyStKpvWn5/VI6b6K1AjkoKAKqcWCS1aL4KfX M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s6jzdx bU2fUmcGx42nvorjMaOH4Pg84gQ7Pwx5KTSvc=; b=EO5nZS1xJksqDX+7GcKShp 8MhxhRURoUVgktciYbW+yIpmwcWZaCqetT2IcN1iZ1NkiBhiFH6avHr7V3w1Z3sC qvaGvQB4EzKzVc8YIdUbAuhf4t29EdJdLgsRyVYRNmBrRyE75WeJ0ndNo+J40RF9 eGVeusEYPwvlNAJKr4LkqhrdGy0D0fzwd27niWcs/PeeCVqc5bXT7Zrv9+J4Zimt iNnZsu3gcbCnSfzgzrtnFiDB9RDBXk6OznTGA0kQ4PlZsCvVFKKRpXNUksnu7YRz wgIL9WetkG0NocR+yirSk7fba28GrY4NouIHKnShvwRZ4YVH1UKQWWyMsh18KhLQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5969AE50B3; Tue, 27 Mar 2018 12:34:09 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, jianfeng.tan@intel.com, konstantin.ananyev@intel.com, harry.van.haaren@intel.com Date: Tue, 27 Mar 2018 18:33:54 +0200 Message-ID: <3396888.LEadjR7LpM@xps> In-Reply-To: <5d94df0912159b96aa71da5249598bd8c744a198.1522159146.git.anatoly.burakov@intel.com> References: <5d94df0912159b96aa71da5249598bd8c744a198.1522159146.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:34:10 -0000 27/03/2018 15:59, Anatoly Burakov: > Under the hood, we create a separate thread to deal with replies to > asynchronous requests, that will just wait to be notified by the > main thread, or woken up on a timer. I really don't like that a library is creating a thread. We don't even know where the thread is created (which core). Can it be a rte_service? or in the interrupt thread? > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -225,6 +225,7 @@ EXPERIMENTAL { > rte_mp_action_unregister; > rte_mp_sendmsg; > rte_mp_request; > + rte_mp_request_async; So there is rte_mp_request and rte_mp_request_async? You should rename rte_mp_request, I guess. > rte_mp_reply; > rte_service_attr_get; > rte_service_attr_reset_all;