From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76EB5A0547; Tue, 31 May 2022 14:55:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26F5340143; Tue, 31 May 2022 14:55:08 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 61CE7400EF for ; Tue, 31 May 2022 14:55:07 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 831B786; Tue, 31 May 2022 15:55:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 831B786 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654001706; bh=IibWGA/5Xfi1PUC6Ra4rsNkttdo6PZofMtMDMTwVYZY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kDuNPnpneJst3bJMBTXg2RQvGU9Y5yayWgP/gdFbt88ASV3qo+vdejZSlhVPXtAaq SuiI7fEkqrsScd14zbxISbUB2GUMM318C4h1nKG//W3aAsvDuXkvd8s1VYo+ww6Som 9HRrGq0mJhJbQdRrUuonxgvcHi0/lI479kAcup1Q= Message-ID: <339e0f68-d39b-7708-3710-2c9709e11cb8@oktetlabs.ru> Date: Tue, 31 May 2022 15:54:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support Content-Language: en-US To: Pankaj Gupta , Jochen Behrens Cc: "dev@dpdk.org" References: <20220525004028.24938-1-pagupta@vmware.com> <20220525004028.24938-7-pagupta@vmware.com> From: Andrew Rybchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pankaj, On 5/25/22 20:13, Pankaj Gupta wrote: > Hi Andrew, > >>> Extended interrupt structures, required implementation for additional number of queues > > It is about Vmxnet3_IntrConfExt. > > Vmxnet3_IntrConfExt  is a control data structure shared with ESX. > > ESX introduced it for this version to increase the number of queues that > can be used. > Vmxnet3_IntrConf was used for older hardware versions Thanks, I see. Andrew. > > Thanks, > > Pankaj > > *From: *Andrew Rybchenko > *Date: *Wednesday, May 25, 2022 at 1:46 AM > *To: *Pankaj Gupta , Jochen Behrens > > *Cc: *dev@dpdk.org > *Subject: *Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support > > ⚠External Email > > Hi, Pankaj, > > On 5/25/22 03:40, Pankaj Gupta wrote: >> VMXNET3 version 6 supports some new features, including but not limited to: >> - Increased max MTU up to 9190 >> - Increased max number of queues, both for Rx and Tx >> - Removes power-of-two limitations >> - Extended interrupt structures, required implementation for >>     additional number of queues >> >> Tested, using testpmd, for different hardware versions on ESXi 7.0 >> Update 2. >> >> Signed-off-by: Pankaj Gupta >> Reviewed-by: Jochen Behrens >> --- >>   doc/guides/rel_notes/release_21_08.rst  |   8 + >>   drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++++-- >>   drivers/net/vmxnet3/vmxnet3_ethdev.c    | 220 +++++++++++++++++------- >>   drivers/net/vmxnet3/vmxnet3_ethdev.h    |  10 +- >>   drivers/net/vmxnet3/vmxnet3_rxtx.c      |   2 +- >>   5 files changed, 234 insertions(+), 79 deletions(-) >> >> diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst >> index 4027bd4390..810da2cc1f 100644 >> --- a/doc/guides/rel_notes/release_21_08.rst >> +++ b/doc/guides/rel_notes/release_21_08.rst >> @@ -133,6 +133,14 @@ New Features >> >>   * **Added RETA query and RETA update support for vmxnet3.** >> >> +* **Added vmxnet3 version 6 supports with some new features.** >> + >> +  * Increased max MTU up to 9190 >> +  * Increased max number of queues, both for Rx and Tx >> +  * Removes power-of-two limitations >> +  * Extended interrupt structures, required implementation for additional number >> +of queues >> + > > I've realized that I don't understand the last bullet. Could > you clarify it, please, and I'll update it on applying. > > Also, JFYI, you should update release notes for 22.07 release, not old > release notes for 21.08. Don't worry about it now - > I'll move and rephrase it on applying. > > Thanks, > Andrew. > > ________________________________ > > ⚠External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >