Re: [PATCH] app/testpmd: dump private info in 'show port info'

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 3/15/2023 2:33 AM, Chengwen Feng wrote:
> This patch adds dump private info in 'show port info [port_id]' cmd.
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>  app/test-pmd/config.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 018536f177..ab5199f223 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -938,6 +938,11 @@ port_infos_display(portid_t port_id)
>  		printf("unknown\n");
>  		break;
>  	}
> +	printf("Device private info:\n");

Not all drivers support device private info, above should print only
when it is supported.

> +	ret = rte_eth_dev_priv_dump(port_id, stdout);
> +	if (ret < 0)
> +		fprintf(stderr, "  Failed to dump private info with error (%d): %s\n",
> +			ret, strerror(-ret));

Similarly, if driver doesn't support '.eth_dev_priv_dump' it shouldn't
print the above error log.