From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5839A0A02; Tue, 23 Mar 2021 18:04:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B20C8140F8F; Tue, 23 Mar 2021 18:04:45 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id EB2814069E for ; Tue, 23 Mar 2021 18:04:43 +0100 (CET) IronPort-SDR: YJVDs0ULJfy4Ak9RetXgE8tTQbVw3kDFVXTLZrID2JodlnpxyL4U7RpuaqI8Sei7HifGnQI51l m14o8wtme/gw== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="210606336" X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="210606336" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 10:04:13 -0700 IronPort-SDR: 6zAIi57GV2u26JSt0QfGhISvbBGSRFvF9IS2qV/WyrWl8EFPmT9FO4Xk55wscl5ExaaLuIYiK0 99Km1SybJ8tA== X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="604367570" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.14.45]) ([10.252.14.45]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 10:04:12 -0700 To: Tyler Retzlaff , dev@dpdk.org, Ed Czeck Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <33c030de-ba1c-cfd3-da28-800f151d964f@intel.com> Date: Tue, 23 Mar 2021 17:04:08 +0000 MIME-Version: 1.0 In-Reply-To: <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/12/2021 10:20 PM, Tyler Retzlaff wrote: > Introduce a meson option enable_driver_sdk when true installs internal > driver headers for ethdev. this allows drivers that do not depend on > stable api/abi to be built external to the dpdk source tree. > > Signed-off-by: Tyler Retzlaff > --- > lib/librte_ethdev/meson.build | 6 ++++++ > lib/meson.build | 4 ++++ > meson_options.txt | 2 ++ > 3 files changed, 12 insertions(+) > > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > index c37b2e377..4353fa6b7 100644 > --- a/lib/librte_ethdev/meson.build > +++ b/lib/librte_ethdev/meson.build > @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h', > 'rte_mtr_driver.h', > 'rte_tm.h', > 'rte_tm_driver.h') > + > indirect_headers += files( > 'rte_ethdev_core.h', > 'rte_eth_ctrl.h') > > +driver_sdk_headers += files( > + 'ethdev_driver.h', > + 'ethdev_pci.h', > + 'ethdev_vdev.h') > + > deps += ['net', 'kvargs', 'meter', 'telemetry'] > diff --git a/lib/meson.build b/lib/meson.build > index 7712aa497..992ebdf63 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -67,6 +67,7 @@ foreach l:libraries > sources = [] > headers = [] > indirect_headers = [] # public headers not directly included by apps > + driver_sdk_headers = [] # public headers included by drivers > includes = [] > cflags = default_cflags > objs = [] # other object files to link against, used e.g. for > @@ -105,6 +106,9 @@ foreach l:libraries > dpdk_conf.set('RTE_LIB_' + name.to_upper(), 1) > install_headers(headers) > install_headers(indirect_headers) > + if get_option('enable_driver_sdk') > + install_headers(driver_sdk_headers) > + endif > dpdk_chkinc_headers += headers > > libname = 'rte_' + name > diff --git a/meson_options.txt b/meson_options.txt > index 6eff62e47..857874a19 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -8,6 +8,8 @@ option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', > description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.') > option('enable_docs', type: 'boolean', value: false, > description: 'build documentation') > +option('enable_driver_sdk', type: 'boolean', value: false, > + description: 'install internal driver plugin headers') > option('enable_kmods', type: 'boolean', value: false, > description: 'build kernel modules') > option('examples', type: 'string', value: '', > +Ed, who was looking way to install 'ark_ext.h' for Ark PMD. Ed, Can you please review the patch from your perspective?