From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AD3C43877; Tue, 9 Jan 2024 19:06:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EBE6402E0; Tue, 9 Jan 2024 19:06:20 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) by mails.dpdk.org (Postfix) with ESMTP id 69EAC4021F for ; Tue, 9 Jan 2024 19:06:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+xiqqsga/6WmOGKLYxYx7JfFj0WyYUcCk2l5gYBr6G4R/PJDHoasROgW66dkxnmCCVhT4Djj83AwpcNNyNkpaDfgLOlr7Az+UD6jPIxHNSGYnrEkm92CJUbF9ju219CeQuusw6lg2YLXlcRXGcgwiEfnOIXneJOhCp2xOU3jC7WoL2494XPfTLRP68C1GaDWWyUNuCcKkE0F38twuaWrnF/HcRf47v0EtqwUiXGJv1UnUqZf4vzmv1dn5chf5koqPzGVUtibezAGdtRXCih82H88lko2Xv1vQdRS/f/cN0l7xOnfo0vMn2lzVs7P94NFzF2tZLLy1q7slUW1EFwvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zjkNVp458XOsI4IqyLBNACagOShhzFGR5sekvaTEIeY=; b=LpcEV8xV0dXmIlWoxqH0Ve+UfnFFD0J7Mu1G6Pm1+VqqM6R8GDIe2VwRE01JSlSlb+LTzmagyjVSyr3Of1RN/L7UCkJf86xMZKDHfV5+UAlIbz1fwlEjAJPMNYDi86mdYZi3bKuqoJDuEJdzeUGq9mcnmBGzfKR2QD+s5s5cWL2VfgNlN0qRGv0HqKf9LiCNBf9xRxNLfUBstvSYwjoBk1/hhyG1xDPldvjEarxt0zR+J96aA5qQpAuVp1HiWVVMrO/hcrFEvbdcsxAV3m9+2OHOXpv1OjZy6NPYNfnf2dkc9Ku13PJqwG48n9K5wJvnVDIUVGI7LP7KZKxXzeSWnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjkNVp458XOsI4IqyLBNACagOShhzFGR5sekvaTEIeY=; b=uy6ci/Rw7VvKM8NK8SvtWprtJFhyzXiFcP+qHCMFqfqPnr7jIgkAvAdqC3wSjxLbnDuS6ZcjtPbal4lsiFFUj+EOr54XWgjKZxgj8bGErbH5OagVIELM1bLm5uKy53GMUMdwH3U4eZ0vpEwilSV83bzXtZiutZQK/Q33kH3/ifI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY5PR12MB4099.namprd12.prod.outlook.com (2603:10b6:a03:20f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 18:06:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 18:06:11 +0000 Message-ID: <33d1d451-95ea-48fe-a6ec-b86976ba5130@amd.com> Date: Tue, 9 Jan 2024 18:06:04 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: add dump regs for telemetry Content-Language: en-US To: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Bruce Richardson Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20231214015650.3738578-1-haijie1@huawei.com> <8632690b-5e85-43fb-9121-a8910074726d@amd.com> <359de0d6-90c4-aaea-f186-574d04a31c2a@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <359de0d6-90c4-aaea-f186-574d04a31c2a@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY5PR12MB4099:EE_ X-MS-Office365-Filtering-Correlation-Id: badf07a2-fd80-49f9-825d-08dc113da929 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XGQBHyUywL9x/F3iEIx3MOC/z5CbRDc6Ago32AygHJTW3Hsns/nH0PCJIGgJlBzseyHK7kXp1eHm7rjMiS6kbJk/P2d7p9t82UIofTA48a47dhvxJ1iMdZqbOnQ88BSVyINBF/XqcGOrBcBLCxcOqvn823GJxttuFayQ+Bcs5kAV8QLj/N57+Sg1mbTPJl8c5VXpHxf3S12+D2o5Zu39zSXtM0F5gf/uxAfTRVFUxnXT6Er+xc4YOEcfu6e36OsOf2NXH2zD7rDpor/shftbFAAbL5dcBzA+scKwfNO31dgafca1WOEn2e+ORBzaZhCD0qBKPE2qh4oOSmckHRDfBRi9daCnoNVlGJav5Ft2eybeuL2b+b82qgRyxDOXwub1yybL9229LNT1zUlyERTpkG5Kxow0RNB9bxHKftd8pd9EzTvwyeYMM2VLy1GguIhyQG7tUy+pf//Bz5OX1uQWJglCLCwsS2BwzNQZ3FvnjNsxat3LfEDIbU6AJ7qMKWVoSOqUeoQD+zpMdAs47qYql4G9rnbOuxnBzb7bykQyFv2NWztu+ibyrd0T9CFsDJvvK5qDE+QUnT0e6qENpoXBkbAJb64Wfl1QzVMH77KAUSFnZMbrOLjJekAHxFvnjVhzJSXdH/WG5wsctsyn9Jdhng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(376002)(136003)(39860400002)(366004)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(6512007)(6506007)(53546011)(8676002)(8936002)(44832011)(36756003)(26005)(41300700001)(38100700002)(31696002)(86362001)(5660300002)(2906002)(2616005)(4326008)(66946007)(66556008)(66476007)(6666004)(6486002)(31686004)(478600001)(316002)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFBSV2xwWHBRL0s3NnE1SGtFSldVV1pNRDdCanJ1L2tZdGVRMmg3UFB4enVN?= =?utf-8?B?aER3dFNuMEVhNW5GSnZpUEhXcmZSajYwOERQSlJHdFhielZzZG9sMmI3dmJS?= =?utf-8?B?WTNjZ1lWeW44VmhuZUJwL3oxSEJxMmN3NEh3d2ZuRUFKcnROUnJxUFZBL2VL?= =?utf-8?B?M2FJZXFtQjMrUkpMcU9nckIwRGM2UVpDd2Z5ZjBuN0NBT0pkSWg5b2lDL1h1?= =?utf-8?B?NXRuZ0plVzV6dUlLeGswUnc0SFo1QS96bS9HQ2VzOFJ6UWZmVk1xSWw2NjFI?= =?utf-8?B?aHBMbEFZUW4zU1BNRy9QbjYySU1laTBLNVM3WlZMeG5KNG5ZWWNwLytRMjFw?= =?utf-8?B?NyswZWg3Y3QzVU5lVEtVODJwRWJYTWF6QjVpQmpMcjFxdzlkaUh6M2J5ZC9n?= =?utf-8?B?b0hUU0xNWHhMaGFQZ2NLdm5kUk84bDVML2RXR3NiWWt4cjVQNEwyL2FJZEZm?= =?utf-8?B?Y1lXY0VJRFVuVEZ0dnhkT0VKQVlJRFg5QnZXbVFsNHVTd1J1V3VRZlhrWTFK?= =?utf-8?B?MCtNNkVvZFVEWXlkK3Q4ZEg5T29xMU50bG1jZ2FHbGtvK3kvb2VCNXI1NmFz?= =?utf-8?B?VXhneC9RcHF2dXcreVUwK1MremRYWEJpU3g4RHR1ekRWa2FMRWZReXVhS1FZ?= =?utf-8?B?dVlVcHU4em5JbjdESCtoOGdaUGJYSlRJMldFemhsZzk4NGlQODhwcmswNy95?= =?utf-8?B?VWtmS1V5anlsSUtsQlFyYXlkRnMxaSsxTlEzR3VTbFlGTW95Yi82SitJS05M?= =?utf-8?B?S2VrZTBtOFFnbG1lSmtYaVNXMXc1VlFZZWh1S3RvejJSTGtrZENBRXlUbWxM?= =?utf-8?B?UHo5YnIvN0VoUHdhSVZ3UG5OQ0l6MU0ybjBjS1dSVnpTU1VXaEZXUHpzZ1Ux?= =?utf-8?B?eXdJNEVOeEQ4UVRoUXBaenZBRVNYK2dBUXcyWFFRckNPR2pCdVExdGpXbHA0?= =?utf-8?B?SGloMGVRVU1VUW9tVEhSR3NoZXgrN1k1Tit1NDRkZDVGQmxHd3MrbVc3YmlP?= =?utf-8?B?YVZVZHhEY21OMzBXMkxMYlpkeVFqUmpCUm1pNS8vUGJ5QS9vRnFQWnRZRUxC?= =?utf-8?B?MzRpaGMxaFk4cnBWTUpCQzl1eWhaNUIxK29mMW1oTFMwVTV0dEk1RGdsQlpN?= =?utf-8?B?bDhJUDVDWnR1UCt5ak8xeDhHeHNTM0l5bisyR0VmQWZzb3pKWFljR01sQ3RJ?= =?utf-8?B?Y2UwSmdWL2FBUmlENDByRWVLWGtRd0x1S1R6Qkkxb0Rxdlg5cElKN3d0L094?= =?utf-8?B?b1daNGp3UDBNakFTUHVrOG0vNlZveXpZUEZCeW14ZE9CdVRPQmNvcVBrTUJH?= =?utf-8?B?eldPWG8zMHpKam1CM1U2NHBvMy9sZ1M4UWVUMmJpM1h5TWgyZ3F3WFhoeWdO?= =?utf-8?B?QnhZdXNyblo5c0ZyZUJnbFZSdkxOM052azg0MUdxTUgzTnRpR3l0dGVKZ0tJ?= =?utf-8?B?Zk5BdmZ3NTRTZDRvQVV3QTVVTnJudVNUQmhRUEJUcWYvbnlqdWI0TGw5a2F3?= =?utf-8?B?VDVudXFXSEhhUG1GZXBWM1JEQ1VKa21kNkwvbHQ4WUNnOFdRRU9QdWJjVVBo?= =?utf-8?B?VUgyS0xEa2R2Q1E1aTF5L09jYjRkMEJ5UHVRRW0xRjVqUUpZRWNBNVFHaUVF?= =?utf-8?B?MXlBRG5iT3c0aVRhU3pwNGNhdVNSczk3YUFVYnJEREk2VlpxeFVIdERyWWRM?= =?utf-8?B?c0xkWUtLZHFaL3dMTlVFU0FpVTlRUjJFblErV1htZ0hMVDQzZWhDanN2QWwr?= =?utf-8?B?bGZyZTY2QmFpV1U1ZDRPQ3IyNlF0dkhaVHMxa1AyNWNjQ1NIN21MNmNFRnhU?= =?utf-8?B?TXF6UzlpWWZkQkxISmRKekkyVGFGL1lqdkxTaUI5RnRJYk5kOW1BRmFEelpM?= =?utf-8?B?SHExZkJ3TjZ5TXZpNjJQQTJlVUY1cWNIVC9KTlRoQStZVFRBYXF1Mit6UWlk?= =?utf-8?B?cjN6eGNTRXYyL2lZMFRJYzkxbDRITlFLZ3hsbnZmNFhOZ0MxRWtaM0dVTnpx?= =?utf-8?B?Q1l0TXJwUHZvOG9BSDdxVUpPR3d6WG5uVi9HTkk0c215cjlwYjVOalNEOWJs?= =?utf-8?B?Y0gzQldadjIvaitEWFN1cUVhQTc5TzM0c3ZWalI3WWtNRUVvcHJhZHFLak1u?= =?utf-8?Q?iVYg=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: badf07a2-fd80-49f9-825d-08dc113da929 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 18:06:11.1344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cC/JhkBQ5GcCu9MD62yJiqmlgP6c0m61KAENtOHtI6erc44/8lMi2iD7h09jlYET X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4099 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/9/2024 2:19 AM, Jie Hai wrote: > On 2023/12/14 20:49, Ferruh Yigit wrote: >> On 12/14/2023 1:56 AM, Jie Hai wrote: >>> The ethdev library now registers a telemetry command for >>> dump regs. >>> >>> An example usage is shown below: >>> --> /ethdev/regs,test >>> { >>>    "/ethdev/regs": { >>>      "regs_offset": 0, >>>      "regs_length": 3192, >>>      "regs_width": 4, >>>      "device_version": "0x1080f00", >>>      "regs_file": "port_0_regs_test" >>>    } >>> } > >> >> Above code writes register data to a file. >> >> I am not sure about this kind of usage of telemetry command, that it >> cause data to be written to a file. >> >> My understanding is, telemetry usage is based on what telemetry client >> receives. >> What do you think just keep the 'reg_info' fields excluding data to the >> file? >> >> .Hi, Ferruh > > I tried to write all register information to telemetry data, > but gave up because some drivers had too many registers (eg.ixgbe) > to carry. Therefore, the writing data to file approach is selected. > > When we query a register, the register content is the key. > The information such as the width and length is only auxiliary > information. If the register data cannot be obtained, the auxiliary > information is optional. So I don't think register data should be removed. > > In my opinion, writing a file is a more appropriate way to do it. > I wonder if there's a better way. > > Is there a usecase to get register information from telemetry interface?