From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED780A034C; Mon, 24 Oct 2022 12:47:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E087A42B6E; Mon, 24 Oct 2022 12:47:39 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id D327540693 for ; Mon, 24 Oct 2022 12:47:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0S9o8DiZwNd2E7Lx+jnVZKcw2251JHMtWlEang7GjzW0Ri9UNO0JMhYLb5Yp1oaW146URGfMqGFGqbt5EXEmBStiV0LpNboghxCP3RR/LI83tN3i71BSdmb0v2di07m8jRrAV/FDhgr355N4jwTAHlBj+D4XtJ+Yyax0jIXpuKj6AzYR7pAAbKKxA4fjcIIMJ7phynCqDtvzw9mog3ddVdzCB4JzgiKZTp0GnS4cvrQ9AYMQvG6kA+S7IMtqYoIM2IQ5Uh27ibUYTxJPjyn3Q9qDInkGZ4ReGWIVMS6VS6evcBq3kBu2HHFcki55XVpj3e2akA4Uop4tf4KVrPLVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EX6VoKlPZZu6epohgmO4qSYqOHMNK76NuD1cV7pVtzk=; b=ESfcWk+2WNs7tdfJ7PAP9Q8VqMg/WDD1yb73kavSn1Xh/e8sgQr8UJkpXnJKboe94Pzxv0SkvJlzlviHRme4bO3g6l4AAGZ1L6hC2xJE8mCB0Pal/6KNA3PRIJktxHG2t6sYFgeFRZUOAtX4ylZNAV1ZvKHnYeA5fzxERsGNGYvVUdhf7YMVnfXYdKXJczXX/gAulHFgVYed6DX8fk+yetOubeBuRKrUr6pqnK81EDuv84HiICgAxcwEf20GCKJnL9yrPLuGBhs5icoQXlzq5/ySHCObCVRjU0/++EzQHQcbIXVvSEjlU0/55bHyjIOSIyfkKJGW/S0wHlGiKgo0Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EX6VoKlPZZu6epohgmO4qSYqOHMNK76NuD1cV7pVtzk=; b=ZNVhhjMdgXhxHZo8QNawne8/58SIQT4iGSEVJLwlPk8be8+ESC4o/iZ0DlOskM7DwZ6ShIhcK6DaFniQv3M09/qfjQ9FzDdtzplWzTowtV+qBGHpM2i9CUxALc8dJO0DFGZOAWbEED94rFGWzdd4od1cHXfQpyM7+WwEYRY9F/A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by SN7PR12MB6959.namprd12.prod.outlook.com (2603:10b6:806:261::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 24 Oct 2022 10:47:36 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Mon, 24 Oct 2022 10:47:36 +0000 Message-ID: <33d4a26e-65fb-f44a-6dc6-62605de66268@amd.com> Date: Mon, 24 Oct 2022 11:47:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v7 1/8] net/gve/base: introduce base code Content-Language: en-US To: "Guo, Junfeng" , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" Cc: "dev@dpdk.org" , "Li, Xiaoyun" , "awogbemila@google.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "stephen@networkplumber.org" , "Xia, Chenbo" , "Zhang, Helin" , "Wang, Haiyue" References: <20221020103656.1068036-1-junfeng.guo@intel.com> <20221021091928.2674471-1-junfeng.guo@intel.com> <20221021091928.2674471-2-junfeng.guo@intel.com> <23dad7c2-dbb5-afb4-2797-6ebf3303454d@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|SN7PR12MB6959:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b20d62c-3769-4956-ac5a-08dab5ad29a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2gBn/hYO55Rxj7dgHWuA9tIBKcBgYZ7IyehynpQPnfG3fnjyGEmkeLUu9a1YgOan/JJwKt1NZAwqmh9dxeaMnTm2iZ4NBB94I/tib9sjvRSkN9Xv/S/ytq/Yl3LS4pGAY4GJ7zPIgPmkxrgBEueYESl/MTTUWN6JRIf/kn1sLONXf9LYgGHmHvbqzY+AAS7fVahDMYUyb7qR61vzZyY/tgEcE0WEPSYC8Sf1cvSNUMZDoBoO6gMv3tFroGfsM3LYhqwWwqvdTie1FTFljy/LX8f0Dzvh1TExt8gjTOcbyLUZw8beVVEhQVTYSRyMONDVIqFdQaBkXgqGpENxqdDpnH7kJyp2IX4fWulkcOWC7kYIH2sIrbuWi/SRbg+fnn8iM1Hr7Dl06QN6nRGz5pd4re8gaC44FYHxLfXHtR1Sah2KnRkhtM5YmQCxTBLlMyFZ1a4mfh5JRLTq6+Qcd7pUNw99Qds4bUHrQPxk6TytCFf5tOAAAhb3cMuG7r0yiwWOa1HGzzVFqeADrWsY/FuUYdvd4K2EQCWY8wv2cGy/r5WO3WzbLBsEEli0an59vetqii0SeaPobQGAfMpRfwKPGjsTvnPQKxScg80GBGByuoRXpx9U+VXW2LZLvC7H9cGxXFAZYIpVgBgWcQLAKI0MbrDMVKpr1p5EuNrROrWrAqedSHkUYyaX3/tlZNH+YkS1zA8lUaetlDaayvKFcbCRDw1muSBSJm/T6LA3+UJVS+2c/IP7Lq9X+M4Kw6gEl0drjJeMs7BgldETTvCLRp7Q6YNGxetesgNYUj1B1BNBm0Kg4KyFnVKvNXs9syFvg6Xc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(451199015)(83380400001)(31686004)(966005)(6486002)(54906003)(316002)(478600001)(110136005)(66556008)(8676002)(44832011)(66476007)(7416002)(6666004)(66946007)(38100700002)(4326008)(31696002)(36756003)(8936002)(6512007)(86362001)(26005)(2906002)(53546011)(6506007)(5660300002)(41300700001)(186003)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1FRL253bVpGTm5HdWFXemRmZThCZjdvcXViQWFmVCtoM3FKb29Qb09KOXFF?= =?utf-8?B?bGxrWWFJeFoxYmlPV1dtVk0zK0ZJaTJmcUZCam5ObXoxOWZsdUlyUXlIRFJP?= =?utf-8?B?a2Zrd2x4UUxlbVRKV0tLR1V3TW1iWkNmbWg3UWVCeHZ1T0hiV1ZEeXNERDRt?= =?utf-8?B?WUVmV2FOZDBlRDM4RWw5bStZdGRTczJtd3JPaENNN21OSnZFOW5sVmlHRmZi?= =?utf-8?B?Rk16TUdVVFlpaURsa25iL09DVnZnQ3hzL21iLzFBaDR6Y0d6VHZhV05IWnZ5?= =?utf-8?B?MVBjSk80cElyQVFSVmRzMFJCenVqMm1adFJueVFNR0t0UTFFUG1obWF6cWlH?= =?utf-8?B?SG9taHdBL3cxWFFDRXNtK0J3N3dWbTBhOEpuN1lTMldNeTFhVFdQa2lrb3Bi?= =?utf-8?B?ckd2Y2J4N0tMTlhuanNKWHoxV1ZzVld5OWtaSVI0NlNZR3VvaG9GZTdtR05B?= =?utf-8?B?OWtNLzBsT203VExDcXpMdDNPdzNxTVdPdVVYeEk1NGFzdi9YdnJpQ0E4LzRN?= =?utf-8?B?Q2dQZWNlYWh1MDRmSFU5Rk15WTlRaG9FczhUaXprNUlXR3M3N2tsU0RPRGtF?= =?utf-8?B?N0pFL256bmZUUERRT1pYR2tLeWFodjJ4dmdZUGxvUHF6V1IzQThyM0QyY2di?= =?utf-8?B?TGVJWS9WTEs4Uy9peWJ5Z2QvMlc1b2x0K0phVC9IaG0zK3UwaXRJSHdpOHlU?= =?utf-8?B?Y0F4OXEyNDdEajBRNW9jQzlIQ3hiZUZUdHlzSFV0Yjl3ek4xekpaV3NZU1ZH?= =?utf-8?B?Z3o4NjNPZktJM1FmWFp2QkxST1NJVjNpT0owa3JEazllaHp5WUJnM281OGxC?= =?utf-8?B?SmlHc1lUdU5rMmZzYTRWRllMM21pOGlFWjByZlBKUFRiRVFEM0hDZk45Y1NR?= =?utf-8?B?Y2h3eDJYRW5vM0F0QlpiM0ZvVW1iYzZGbklxa1VjbU5GR25kQVpEeUhzaGxE?= =?utf-8?B?T3R5VUlocGx0Rlp0R2V0K1NJd05zcFBVZlBwaXovZlZlNEpkWVJoc3RyNm1p?= =?utf-8?B?d1Jpd1RXc0d4Tkprb3NPb3pCeTMySEgvRGt0aTVGS3p4NEEyUDRZYUw3T242?= =?utf-8?B?WllVd3UvVlZWaVZhTUlReHRhWCszWGoydkVhU0hHOERmNk5kenI2YVpYbkZt?= =?utf-8?B?L1N5NTVmUUZzclhZZWpQMkkrYkZaT1l4ckhJK3hVOXo0djdldWU0WURNWHFv?= =?utf-8?B?WEhnUnE2VVV5dG90ODdpWFhuOVZnRG42TFpUOVZ3NERBUW54Uy9tNWpTYnFI?= =?utf-8?B?aUJXTS8xSk81SGZUUGJOMFVpeTJTbzFLYUc5dGpHdGpPWlNrbVlGNGp3VHJq?= =?utf-8?B?TmpSK25BODFYd1lEWjdRdEowSk5BUkxvQm85UWM2ZnlQMXNUWWxVcUg5Y2Z4?= =?utf-8?B?allQWGZEVWJWK1RNaXAybGZBSE4vbWJXclZKQkRFTXI1L1dXNzRCeDh5OG0v?= =?utf-8?B?dTRGZ05sZVI2M0tOcHdUZjhUU1NZTksxRGkvVG1RWWN6cnpjalc0L2ErMGhW?= =?utf-8?B?Yk0za1poZDlvWjM4bGpwajFwRXErZDJhVzJsS0pLalZXaFBSNE42MUFpNlhM?= =?utf-8?B?aHI5cXg5KzZ3VVo3QjNEanBBYjd2ZTl3dUdqbHk4WFlCN0M3Vm1reTZOL2p5?= =?utf-8?B?OUwzaXl2S0loUWdMVWhQcTB3RHI0bGYyV1Q4WXp2bVczbzB2WE9aYXA2YUtE?= =?utf-8?B?TmhCUHl1UUFQSVdqT3BMY1pBTUY3TTZ0MHF1ZS9WekoxNzVObzIrWkVCVGhy?= =?utf-8?B?djBDQ0ZMM2ZDeHJXcUFPZ0tlZHJCMVpkQlVMbEZGTGEvbkJGa1FPakRJMVFS?= =?utf-8?B?eHNkTUF5Ym13WFpOMVNIcmZORWxaWXFmZ0IrTjEzaDJNWklvN0xXZC9IdTla?= =?utf-8?B?NzdEbUhlbE8rRHNXUng4U0dCcnNJU2pDSXhlSjlMVWREN3BnOUdNdTFrYjQv?= =?utf-8?B?NURJU2FCWDdCUGxEQ2xhdEh0aGUwRXFLaHYxdmtqbjlFU0xpMFhMQk5udmlq?= =?utf-8?B?YWJtUExtRjZjTXo5RnF1S0xFRGhUWUtXT1dpeE9XSWFCRWVCZlo1aUJhYTZG?= =?utf-8?B?UmlrZmcrUnUxUlVRT2ZrQ3hOaXYvUWYvZDk3Q3JYMlZVRjBJRTBwY3RMemdT?= =?utf-8?Q?16XcB0TWlRzNPaeYkQDpcRxKI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b20d62c-3769-4956-ac5a-08dab5ad29a4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:47:36.0692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FqVuBigcVcA/WRSxO1NTL2Il0QLCUwPVz0EdOe32gmJSksXcRnLC95XtlWzEMH7w X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6959 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/2022 6:04 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, October 21, 2022 17:49 >> To: Guo, Junfeng ; Zhang, Qi Z >> ; Wu, Jingjing ; Xing, >> Beilei >> Cc: dev@dpdk.org; Li, Xiaoyun ; >> awogbemila@google.com; Richardson, Bruce >> ; hemant.agrawal@nxp.com; >> stephen@networkplumber.org; Xia, Chenbo ; >> Zhang, Helin ; Wang, Haiyue >> >> Subject: Re: [PATCH v7 1/8] net/gve/base: introduce base code >> >> On 10/21/2022 10:19 AM, Junfeng Guo wrote: >>> The following base code is based on Google Virtual Ethernet (gve) >>> driver v1.3.0 under MIT license. >>> - gve_adminq.c >>> - gve_adminq.h >>> - gve_desc.h >>> - gve_desc_dqo.h >>> - gve_register.h >>> - gve.h >>> >>> The original code is in: >>> https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- >> linux/\ >>> tree/v1.3.0/google/gve >>> >>> Note that these code are not Intel files and they come from the kernel >>> community. The base code there has the statement of >>> SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the >>> required MIT license as an exception to DPDK. >>> >>> Signed-off-by: Xiaoyun Li >>> Signed-off-by: Haiyue Wang >>> Signed-off-by: Junfeng Guo >> >> <...> >> >>> +static bool gve_adminq_wait_for_cmd(struct gve_priv *priv, u32 >> prod_cnt) >>> +{ >>> + int i; >>> + >>> + for (i = 0; i < GVE_MAX_ADMINQ_EVENT_COUNTER_CHECK; i++) >> { >>> + if (ioread32be(&priv->reg_bar0->adminq_event_counter) >>> + == prod_cnt) >> >> [copy/paste from previous version] >> >> Syntax, why not move second half of the equation in above line? >> Unless this is coming from google code and updating it brings >> maintanance cost. > > Yes, this function is just coming from google code without changes. > So it would be better to keep this unchanged. Thanks! > ack