DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dekel Peled <dekelp@mellanox.com>
To: ferruh.yigit@intel.com, arybchenko@solarflare.com,
	orika@mellanox.com, john.mcnamara@intel.com,
	marko.kovacevic@intel.com
Cc: asafp@mellanox.com, matan@mellanox.com, elibr@mellanox.com, dev@dpdk.org
Subject: [dpdk-dev] [RFC v2] ethdev: add extensions attributes to IPv6 item
Date: Mon,  3 Aug 2020 20:01:30 +0300
Message-ID: <33de39c7ef627b87f5e0bb34f364a92fffc39fc5.1596470130.git.dekelp@mellanox.com> (raw)
In-Reply-To: <5f9b4d30b81fa68ed875106785419a43cc7a6166.1590935677.git.dekelp@mellanox.com>

Using the current implementation of DPDK, an application cannot match on
IPv6 packets, based on the existing extension headers, in a simple way.

Field 'Next Header' in IPv6 header indicates type of the first extension
header only. Following extension headers can't be identified by
inspecting the IPv6 header.
As a result, the existence or absence of specific extension headers
can't be used for packet matching.

For example, fragmented IPv6 packets contain a dedicated extension header,
as detailed in RFC [1], which is not yet supported in rte_flow.
Non-fragmented packets don't contain the fragment extension header.
For an application to match on non-fragmented IPv6 packets, the current
implementation doesn't provide a suitable solution.
Matching on the Next Header field is not sufficient, since additional
extension headers might be present in the same packet.
To match on fragmented IPv6 packets, the same difficulty exists.

Proposed update:
A set of additional values will be added to IPv6 header struct.
These values will indicate the existence of every defined extension
header type, providing simple means for identification of existing
extensions in the packet header.
Continuing the above example, fragmented packets can be identified using
the specific value indicating existence of fragment extension header.

This update changes ABI, and is proposed for the 20.11 LTS version.

[1] http://mails.dpdk.org/archives/dev/2020-March/160255.html

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 lib/librte_ethdev/rte_flow.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index da8bfa5..8d2073d 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -792,11 +792,33 @@ struct rte_flow_item_ipv4 {
  *
  * Matches an IPv6 header.
  *
+ * Dedicated flags indicate existence of specific extension headers.
+ *
  * Note: IPv6 options are handled by dedicated pattern items, see
  * RTE_FLOW_ITEM_TYPE_IPV6_EXT.
  */
 struct rte_flow_item_ipv6 {
 	struct rte_ipv6_hdr hdr; /**< IPv6 header definition. */
+	uint64_t hop_ext_exist:1;
+	/**< Hop-by-Hop Options extension header exists. */
+        uint64_t rout_ext_exist:1;
+        /**< Routing extension header exists. */
+        uint64_t frag_ext_exist:1;
+        /**< Fragment extension header exists. */
+        uint64_t auth_ext_exist:1;
+        /**< Authentication extension header exists. */
+        uint64_t esp_ext_exist:1;
+        /**< Encapsulation Security Payload extension header exists. */
+        uint64_t dest_ext_exist:1;
+        /**< Destination Options extension header exists. */
+        uint64_t mobil_ext_exist:1;
+        /**< Mobility extension header exists. */
+        uint64_t hip_ext_exist:1;
+        /**< Host Identity Protocol extension header exists. */
+        uint64_t shim6_ext_exist:1;
+        /**< Shim6 Protocol extension header exists. */
+        uint64_t reserved:55;
+        /**< Reserved for future extension headers, must be zero. */
 };
 
 /** Default mask for RTE_FLOW_ITEM_TYPE_IPV6. */
-- 
1.8.3.1


  parent reply	other threads:[~2020-08-03 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 14:43 [dpdk-dev] [RFC] ethdev: add fragment attribute " Dekel Peled
2020-06-01  5:38 ` Stephen Hemminger
2020-06-01  6:11   ` Dekel Peled
2020-06-02 14:32 ` Andrew Rybchenko
2020-06-02 18:28   ` Ori Kam
2020-06-02 19:04     ` Adrien Mazarguil
2020-06-03  8:16       ` Ori Kam
2020-06-03 12:10         ` Dekel Peled
2020-06-18  6:58           ` Dekel Peled
2020-06-28 14:52             ` Dekel Peled
2020-07-05 13:13       ` Andrew Rybchenko
2020-08-03 17:01 ` Dekel Peled [this message]
2020-08-03 17:11   ` [dpdk-dev] [RFC v3] ethdev: add extensions attributes " Dekel Peled

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33de39c7ef627b87f5e0bb34f364a92fffc39fc5.1596470130.git.dekelp@mellanox.com \
    --to=dekelp@mellanox.com \
    --cc=arybchenko@solarflare.com \
    --cc=asafp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=elibr@mellanox.com \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git