From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 260A8A0471 for <public@inbox.dpdk.org>; Mon, 12 Aug 2019 12:38:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B43749E0; Mon, 12 Aug 2019 12:38:11 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1BF3A374 for <dev@dpdk.org>; Mon, 12 Aug 2019 12:38:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 03:38:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,377,1559545200"; d="scan'208";a="259738638" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.78]) ([10.237.220.78]) by orsmga001.jf.intel.com with ESMTP; 12 Aug 2019 03:38:05 -0700 To: David Marchand <david.marchand@redhat.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Hemant Agrawal <hemant.agrawal@nxp.com>, Gagandeep Singh <G.Singh@nxp.com>, dev <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Nipun Gupta <nipun.gupta@nxp.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Steve Capper <steve.capper@arm.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, Gavin Hu <gavin.hu@arm.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, David Christensen <drc@linux.vnet.ibm.com> References: <20190807101204.21614-1-g.singh@nxp.com> <52183700.OczlixnxyG@xps> <VI1PR0401MB25416710B44AAD881BED4D1389D40@VI1PR0401MB2541.eurprd04.prod.outlook.com> <15982978.NnXy4IA2Yx@xps> <525631f9-c367-336e-7caf-dbb886193fc6@intel.com> <CAJFAV8yw+p-KE-PeFbZD8N8zgMNqwfMg_T73er5r9jT_a92a3g@mail.gmail.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <33e6adae-d6ed-4b3f-1e9a-eb592bc067e4@intel.com> Date: Mon, 12 Aug 2019 11:38:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <CAJFAV8yw+p-KE-PeFbZD8N8zgMNqwfMg_T73er5r9jT_a92a3g@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 12-Aug-19 10:49 AM, David Marchand wrote: > On Mon, Aug 12, 2019 at 11:43 AM Burakov, Anatoly > <anatoly.burakov@intel.com> wrote: >> On 08-Aug-19 8:31 AM, Thomas Monjalon wrote: >>> I would suggest to restrict the change to Arm only with an ifdef, >>> in order to limit the risk for this release. >>> We can think about a dynamic hugepage scan in the next release. >>> >> >> I don't see how this is necessary. The 3 is an arbitrary number here, >> and the ABI isn't broken as this is an internal structure. We could >> increase it to 16 for all i care, and it wouldn't make any difference to >> the rest of the code - we never populate more than we can find anyway. > > I agree on the principle. > But at the time this popped up, we were really close to the release. > It seemed a way to mitigate any unforeseen issue by limiting to the > platform that was affected. > Fair enough. A follow up is needed so. Frankly, i don't see the need to complicate things with "dynamic" stuff here - a static array of 8 or 16 page sizes should be enough for everyone (TM). -- Thanks, Anatoly